From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] gpio: drop CONFIG_OF_GPIO in the definition of the struct gpio_chip
Date: Mon, 13 Feb 2012 11:18:10 +0100 [thread overview]
Message-ID: <4F38E362.6010307@atmel.com> (raw)
In-Reply-To: <1329125002-21134-1-git-send-email-plagnioj@jcrosoft.com>
On 02/13/2012 10:23 AM, Jean-Christophe PLAGNIOL-VILLARD :
> this will allow to avoid the ifdef CONFIG_OF_GPIO in gpio drivers
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
> Cc: Arnd Bergmann <arnd@arndb•de>
> Cc: Nicolas Ferre <nicolas.ferre@atmel•com>
Added devicetree-discuss ml.
> ---
> include/asm-generic/gpio.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
> index 1ff4e22..c08b758 100644
> --- a/include/asm-generic/gpio.h
> +++ b/include/asm-generic/gpio.h
> @@ -122,7 +122,6 @@ struct gpio_chip {
> unsigned can_sleep:1;
> unsigned exported:1;
>
> -#if defined(CONFIG_OF_GPIO)
> /*
> * If CONFIG_OF is enabled, then all GPIO controllers described in the
Maybe you will need to rework this comment.
> * device tree automatically may have an OF translation
> @@ -131,7 +130,6 @@ struct gpio_chip {
> int of_gpio_n_cells;
> int (*of_xlate)(struct gpio_chip *gc,
> const struct of_phandle_args *gpiospec, u32 *flags);
> -#endif
I do not know if we can remove the ifdef completely of just move of_node
out of it.
> };
>
> extern const char *gpiochip_is_requested(struct gpio_chip *chip,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-02-13 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 9:23 [PATCH 1/1] gpio: drop CONFIG_OF_GPIO in the definition of the struct gpio_chip Jean-Christophe PLAGNIOL-VILLARD
2012-02-13 10:18 ` Nicolas Ferre [this message]
2012-02-13 10:37 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-13 14:00 ` Rob Herring
2012-02-13 14:12 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-13 14:33 ` Rob Herring
2012-02-13 14:59 ` Nicolas Ferre
2012-02-14 1:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F38E362.6010307@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox