From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: S3C24XX: Fix restart on S3C2442
Date: Thu, 16 Feb 2012 21:00:56 +0900 [thread overview]
Message-ID: <4F3CEFF8.8020904@samsung.com> (raw)
In-Reply-To: <201202160843.48203.heiko@sntech.de>
On 02/16/12 16:43, Heiko St?bner wrote:
> Hi Kgene,
>
> Am Sonntag, 12. Februar 2012, 14:59:54 schrieb Heiko St?bner:
>> Commit b27b072791dc (ARM: 7265/1: restart: S3C24XX: use new restart hook)
>> introduced the new restart hook also for the S3C244x cpus, but it
>> was only defined in the S3C2440 scope, i.e. when CPU_S3C2440 was
>> selected. Devices using the S3C2442 like the GTA02 normally don't select
>> this CPU which leads to compilation errors like:
>> LD .tmp_vmlinux1
>> arch/arm/mach-s3c2440/built-in.o:(.arch.info.init+0x3c): undefined
>> reference to `s3c2440_restart' make: *** [.tmp_vmlinux1] Error 1
>>
>> Therefore move the s3c2440_restart function to s3c244x.c which is
>> common to both cpus and also fix the naming to reflect this.
>>
>> Reported-by: Denis 'GNUtoo' Carikli<GNUtoo@no-log•org>
>> Signed-off-by: Heiko Stuebner<heiko@sntech•de>
> could you take a look at this patch and possibly pick it up as fix for the
> current -rcs.
>
Hi,
Yes, looks ok to me. I will apply in v3.3-samsung-fixes-4.
Thanks for fixing and testing :)
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2012-02-16 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1329051929-8303-1-git-send-email-GNUtoo@no-log.org>
2012-02-12 13:57 ` [PATCH] ARM: s3c2440: fix undefined reference to `s3c2440_restart' for machine gta02 Heiko Stübner
2012-02-12 13:59 ` [PATCH] ARM: S3C24XX: Fix restart on S3C2442 Heiko Stübner
2012-02-12 18:57 ` Denis 'GNUtoo' Carikli
2012-02-13 12:29 ` Denis 'GNUtoo' Carikli
2012-02-13 12:58 ` Heiko Stübner
2012-02-16 7:43 ` Heiko Stübner
2012-02-16 12:00 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3CEFF8.8020904@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox