From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [CPUFREQ] Fix exposure of ARM_EXYNOS4210_CPUFREQ
Date: Thu, 16 Feb 2012 21:17:30 +0900 [thread overview]
Message-ID: <4F3CF3DA.7000806@samsung.com> (raw)
In-Reply-To: <20120213094940.GA15338@n2100.arm.linux.org.uk>
On 02/13/12 18:49, Russell King - ARM Linux wrote:
> From: Russell King<rmk+kernel@arm•linux.org.uk>
>
> exynos4210-cpufreq.c is not buildable on non-exynos builds, so it's
> pointless allowing this option to be exposed. Fix this by adding a
> dependency on ARCH_EXYNOS.
>
> drivers/cpufreq/exynos4210-cpufreq.c:20:29: error: mach/regs-clock.h: No such file or directory
> drivers/cpufreq/exynos4210-cpufreq.c:21:26: error: mach/cpufreq.h: No such file or directory
>
> Signed-off-by: Russell King<rmk+kernel@arm•linux.org.uk>
> Cc: Dave Jones<davej@redhat•com>
> Cc: cpufreq at vger.kernel.org
> Cc: Kukjin Kim<kgene.kim@samsung•com>
> ---
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index e0664fe..c8bde43 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -34,6 +34,7 @@ config ARM_EXYNOS_CPUFREQ
>
> config ARM_EXYNOS4210_CPUFREQ
> bool "Samsung EXYNOS4210"
> + depends on ARCH_EXYNOS
> help
> This adds the CPUFreq driver for Samsung EXYNOS4210
> SoC (S5PV310 or S5PC210).
>
Yes, you're right. Should be added it.
BTW, how about following?
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index e0664fe..a5e0487 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -33,7 +33,7 @@ config ARM_EXYNOS_CPUFREQ
If in doubt, say N.
config ARM_EXYNOS4210_CPUFREQ
- bool "Samsung EXYNOS4210"
+ bool
help
This adds the CPUFreq driver for Samsung EXYNOS4210
SoC (S5PV310 or S5PC210).
I think, when selecting "ARM_EXYNOS_CPUFREQ", "ARM_EXYNOS4210_CPUFREQ"
will be selected on EXYNOS4210 with above changes.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-02-16 12:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 9:49 [CPUFREQ] Fix exposure of ARM_EXYNOS4210_CPUFREQ Russell King - ARM Linux
2012-02-16 12:17 ` Kukjin Kim [this message]
2012-02-16 16:02 ` Russell King - ARM Linux
2012-02-21 10:35 ` Kukjin Kim
2012-03-27 7:49 ` Russell King - ARM Linux
2012-03-29 0:59 ` Kukjin Kim
2012-04-04 14:52 ` Russell King - ARM Linux
2012-04-04 14:59 ` 'Dave Jones'
2012-04-04 15:03 ` Russell King - ARM Linux
2012-04-04 15:07 ` Russell King - ARM Linux
2012-04-04 15:13 ` Russell King - ARM Linux
2012-04-04 16:48 ` Kukjin Kim
2012-04-04 16:43 ` Kukjin Kim
2012-04-04 16:39 ` Kukjin Kim
2012-04-04 17:05 ` Kukjin Kim
2012-04-04 17:22 ` 'Dave Jones'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3CF3DA.7000806@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox