From: b-cousson@ti•com (Cousson, Benoit)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: OMAP2+: hwmod: Add new sysc_type3 into omap_hwmod required for am33xx
Date: Fri, 17 Feb 2012 14:21:35 +0100 [thread overview]
Message-ID: <4F3E545F.8070802@ti.com> (raw)
In-Reply-To: <1329481488-27771-1-git-send-email-hvaibhav@ti.com>
Hi Vaibhav,
On 2/17/2012 1:24 PM, Vaibhav Hiremath wrote:
> In case of AM33xx family of devices (like cpsw) have different sysc
> bit field offsets defined,
It is really used by several IPs, or it is just an unique exception?
For an exception, you can just define the omap_hwmod_sysc_fields for
that IP.
This is what SmartReflex is using for example.
Regards,
Benoit
> sysc_type3:
> | 3 2 | 1 0 |
> | STDBYMODE | IDLEMODE |
>
> So introduce new sysc_type3 in omap_hwmod common data.
>
> Signed-off-by: Vaibhav Hiremath<hvaibhav@ti•com>
> Signed-off-by: Vaibhav Bedia<vaibhav.bedia@ti•com>
> ---
> arch/arm/mach-omap2/omap_hwmod_common_data.c | 9 +++++++++
> arch/arm/plat-omap/include/plat/omap_hwmod.h | 10 ++++++++++
> 2 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_common_data.c b/arch/arm/mach-omap2/omap_hwmod_common_data.c
> index 51e5418..6dd922e 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_common_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_common_data.c
> @@ -49,6 +49,15 @@ struct omap_hwmod_sysc_fields omap_hwmod_sysc_type2 = {
> .srst_shift = SYSC_TYPE2_SOFTRESET_SHIFT,
> };
>
> +/**
> + * struct omap_hwmod_sysc_type3 - TYPE3 sysconfig scheme.
> + * Used by some IPs on AM33xx
> + */
> +struct omap_hwmod_sysc_fields omap_hwmod_sysc_type3 = {
> + .midle_shift = SYSC_TYPE3_MIDLEMODE_SHIFT,
> + .sidle_shift = SYSC_TYPE3_SIDLEMODE_SHIFT,
> +};
> +
> struct omap_dss_dispc_dev_attr omap2_3_dss_dispc_dev_attr = {
> .manager_count = 2,
> .has_framedonetv_irq = 0
> diff --git a/arch/arm/plat-omap/include/plat/omap_hwmod.h b/arch/arm/plat-omap/include/plat/omap_hwmod.h
> index 9db27aa..3128364 100644
> --- a/arch/arm/plat-omap/include/plat/omap_hwmod.h
> +++ b/arch/arm/plat-omap/include/plat/omap_hwmod.h
> @@ -41,6 +41,7 @@ struct omap_device;
>
> extern struct omap_hwmod_sysc_fields omap_hwmod_sysc_type1;
> extern struct omap_hwmod_sysc_fields omap_hwmod_sysc_type2;
> +extern struct omap_hwmod_sysc_fields omap_hwmod_sysc_type3;
>
> /*
> * OCP SYSCONFIG bit shifts/masks TYPE1. These are for IPs compliant
> @@ -70,6 +71,15 @@ extern struct omap_hwmod_sysc_fields omap_hwmod_sysc_type2;
> #define SYSC_TYPE2_MIDLEMODE_SHIFT 4
> #define SYSC_TYPE2_MIDLEMODE_MASK (0x3<< SYSC_TYPE2_MIDLEMODE_SHIFT)
>
> +/*
> + * OCP SYSCONFIG bit shifts/masks TYPE3.
> + * This is applicable for some IPs present in AM33XX
> + */
> +#define SYSC_TYPE3_SIDLEMODE_SHIFT 0
> +#define SYSC_TYPE3_SIDLEMODE_MASK (0x3<< SYSC_TYPE3_SIDLEMODE_SHIFT)
> +#define SYSC_TYPE3_MIDLEMODE_SHIFT 2
> +#define SYSC_TYPE3_MIDLEMODE_MASK (0x3<< SYSC_TYPE3_MIDLEMODE_SHIFT)
> +
> /* OCP SYSSTATUS bit shifts/masks */
> #define SYSS_RESETDONE_SHIFT 0
> #define SYSS_RESETDONE_MASK (1<< SYSS_RESETDONE_SHIFT)
next prev parent reply other threads:[~2012-02-17 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 12:24 [PATCH] ARM: OMAP2+: hwmod: Add new sysc_type3 into omap_hwmod required for am33xx Vaibhav Hiremath
2012-02-17 13:21 ` Cousson, Benoit [this message]
2012-02-21 5:19 ` Bedia, Vaibhav
2012-03-12 10:13 ` Hiremath, Vaibhav
2012-04-28 1:34 ` Paul Walmsley
2012-06-28 14:40 ` Hiremath, Vaibhav
2012-06-28 14:45 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E545F.8070802@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox