From: b-cousson@ti•com (Cousson, Benoit)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] tty: serial: OMAP: block idle while the UART is transferring data in PIO mode
Date: Fri, 24 Feb 2012 15:35:44 +0100 [thread overview]
Message-ID: <4F47A040.6030502@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1202211456160.25023@utopia.booyaka.com>
Salut Paul,
On 2/21/2012 11:02 PM, Paul Walmsley wrote:
> Salut Beno?t,
>
> On Mon, 20 Feb 2012, Cousson, Benoit wrote:
>
>> 3.3-rc4 is broken in the DT case because of the serial driver. And it
>> looks like it is due to this fix. We cannot rely on pdata anymore in
>> DT, and in that case it leads to an Oops due to NULL pdata.
>
> Sorry about the breakage. I agree with the diagnosis. That code was just
> copied from the DMA errata part of the driver, so it will need to be fixed
> as well. Otherwise the same problem will happen when DMA is enabled.
>
>> And then we will have to add the support for all these OMAP custom hooks without pdata.
>
> That's really the key question for the medium- to long-term...
I know you know, I'm always hoping that someone will step up and propose
some cool idea to fix that :-)
>> A basic fix (below) for the moment is to test for valid pdata inside the driver.
>> I'll repost it properly if you are fine with it.
>
> Looks fine to me, although I'd suggest fixing the DMA workaround path as
> well.
Mmm, I've tried to fix every instances of pdata in the code, you think I
missed some?
I'll check again.
> Reviewed-by: Paul Walmsley<paul@pwsan•com>
Thanks,
Benoit
next prev parent reply other threads:[~2012-02-24 14:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 2:50 [PATCH v2 0/3] tty: serial: OMAP: work around broken IP block, driver Paul Walmsley
2012-01-26 2:50 ` [PATCH v2 1/3] tty: serial: OMAP: use a 1-byte RX FIFO threshold in PIO mode Paul Walmsley
2012-01-26 2:50 ` [PATCH 2/3] tty: serial: OMAP: block idle while the UART is transferring data " Paul Walmsley
2012-01-26 2:58 ` Paul Walmsley
2012-01-27 7:23 ` Govindraj
2012-02-20 12:35 ` Cousson, Benoit
2012-02-21 22:02 ` Paul Walmsley
2012-02-24 14:35 ` Cousson, Benoit [this message]
2012-02-28 17:13 ` Paul Walmsley
2012-02-28 17:22 ` [PATCH] tty: serial: OMAP: Fix oops due to NULL pdata in DT boot Cousson, Benoit
2012-02-28 17:28 ` Greg KH
2012-02-28 18:23 ` Kevin Hilman
2012-01-26 2:50 ` [PATCH v2 3/3] tty: serial: omap-serial: wakeup latency constraint is in microseconds, not milliseconds Paul Walmsley
2012-01-27 7:19 ` Govindraj
2012-01-30 19:13 ` [PATCH v2 0/3] tty: serial: OMAP: work around broken IP block, driver Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F47A040.6030502@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox