From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller
Date: Wed, 29 Feb 2012 14:22:27 +0400 [thread overview]
Message-ID: <4F4DFC63.9060509@mvista.com> (raw)
In-Reply-To: <4F4DC8EB.7010201@denx.de>
Hello.
On 29-02-2012 10:42, Heiko Schocher wrote:
>>> Add a function to initialize the davinci interrupt controller (INTC)
>>> using a device tree node.
>> cp_intc is not DaVinci interrupt controller, it's only used in
>> OMAP-L1x SoCs. cp_intc stands for Common Platform Interrupt Controller.
> Ah, Ok! Thanks for the explanation.
>> I don't see where you are initializiing the DaVinci interrupt controller
>> itself. You should understand that there are two disctinct types of
>> interrupt controllers used in the SoCs supported by arch/arm/mach-davinci/.
> board code:
> MACHINE_START(ENBW_CMC, "EnBW CMC")
> [...]
> .init_irq = davinci_init_irq,
> and in arch/arm/mach-davinci/cp_intc.c
> for the of case:
> void __init davinci_init_irq(void)
> {
> of_irq_init(irq_match);
> }
> in drivers/of/irq.c:
> /**
> * of_irq_init - Scan and init matching interrupt controllers in DT
> * @matches: 0 terminated array of nodes to match and init function to call
> *
> * This function scans the device tree for matching interrupt controller nodes,
> * and calls their initialization functions in order with parents first.
> */
> void __init of_irq_init(const struct of_device_id *matches)
> Ok, the name of davinci_init_irq() is missleading ...
> Should I name it "cp_intc_of_init" ?
Probably. At least something with "cp_intc" in the name...
> bye,
> Heiko
WBR, Sergei
next prev parent reply other threads:[~2012-02-29 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 6:50 [PATCH v2 0/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller Heiko Schocher
2012-02-22 12:23 ` Sergei Shtylyov
2012-02-29 6:42 ` Heiko Schocher
2012-02-29 10:22 ` Sergei Shtylyov [this message]
2012-02-22 6:50 ` [PATCH v2 2/7] ARM: davinci: configure davinci aemif chipselects through OF Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 3/7] ARM: davinci: mux: add OF support Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 4/7] ARM: davinci: net: davinci_emac: " Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 5/7] ARM: davinci: i2c: " Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 6/7] ARM: mtd: nand: davinci: add OF support for davinci nand controller Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4DFC63.9060509@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox