From: b-cousson@ti•com (Cousson, Benoit)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 7/7] Document: devicetree: add OF documents for arch-mmp
Date: Mon, 5 Mar 2012 16:08:37 +0100 [thread overview]
Message-ID: <4F54D6F5.8050805@ti.com> (raw)
In-Reply-To: <201203051446.14600.arnd@arndb.de>
On 3/5/2012 3:46 PM, Arnd Bergmann wrote:
> On Monday 05 March 2012, Haojian Zhuang wrote:
>> Add OF support in Document/devicetree directory.
>>
>> Signed-off-by: Haojian Zhuang<haojian.zhuang@marvell•com>
>
> Acked-by: Arnd Bergmann<arnd@arndb•de>
>
> One question for Benoit, Grant or Rob:
>
>> +Required properties:
>> +- compatible: should be "mrvl,sa1100-rtc"
>> +- reg: physical base address of the controller and length of memory mapped
>> + region.
>> +- interrupts: Should be two. The first interrupt number is the rtc alarm
>> + interrupt and the second interrupt number is the rtc hz interrupt.
>> +- interrupt-names: Assign name of irq resource.
>> +
>> +Example:
>> + rtc: rtc at d4010000 {
>> + compatible = "mrvl,mmp-rtc";
>> + reg =<0xd4010000 0x1000>;
>> + interrupts =<5>,<6>;
>> + interrupt-name = "rtc 1Hz", "rtc alarm";
>> + };
>
> When the binding for a device lists the interrupt-names property, should it
> also list the specific values for it? This one says that which ones they are,
> but I think we should actually mandate the exact string in the binding if
> we want to allow drivers to get the resource by its name.
Yes, indeed. The names are not some random strings, the driver will use
get_resource_by_name and expect the name to be aligned with HW
documentation and thus should be well documented in the binding.
Regards,
Benoit
next prev parent reply other threads:[~2012-03-05 15:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 12:21 [PATCH v2 0/7] ARM: mmp: support OF on pxa168 Haojian Zhuang
2012-03-05 12:21 ` [PATCH v2 1/7] serial: pxa: add OF support Haojian Zhuang
2012-03-05 12:55 ` Arnd Bergmann
2012-03-05 14:03 ` Haojian Zhuang
2012-03-06 2:42 ` [PATCH v3 " Haojian Zhuang
2012-03-06 15:02 ` Arnd Bergmann
2012-03-06 15:04 ` Haojian Zhuang
2012-03-07 1:42 ` [PATCH v3 1/6] " Haojian Zhuang
2012-03-07 7:58 ` Arnd Bergmann
2012-03-09 15:24 ` [PATCH v2 1/7] " Grant Likely
2012-04-03 15:45 ` Grant Likely
2012-03-05 12:21 ` [PATCH v2 2/7] rtc: sa1100: " Haojian Zhuang
2012-03-05 14:41 ` Arnd Bergmann
2012-03-05 12:21 ` [PATCH v2 3/7] i2c: pxa: " Haojian Zhuang
2012-03-05 14:41 ` Arnd Bergmann
2012-03-05 12:21 ` [PATCH v2 4/7] ARM: mmp: enable rtc clk in pxa168 Haojian Zhuang
2012-03-05 14:38 ` Arnd Bergmann
2012-03-05 12:21 ` [PATCH v2 5/7] ARM: mmp: append OF support on pxa168 Haojian Zhuang
2012-03-05 14:37 ` Arnd Bergmann
2012-04-09 1:36 ` Chris Ball
2012-04-09 1:46 ` Haojian Zhuang
2012-04-09 1:51 ` Chris Ball
2012-04-09 2:04 ` Haojian Zhuang
2012-04-09 1:43 ` Chris Ball
2012-04-09 1:47 ` Haojian Zhuang
2012-03-05 12:21 ` [PATCH v2 6/7] ARM: dts: append DTS file of pxa168 Haojian Zhuang
2012-03-05 14:35 ` Arnd Bergmann
2012-03-05 12:21 ` [PATCH v2 7/7] Document: devicetree: add OF documents for arch-mmp Haojian Zhuang
2012-03-05 14:46 ` Arnd Bergmann
2012-03-05 15:07 ` Rob Herring
2012-03-05 15:08 ` Cousson, Benoit [this message]
2012-04-02 23:21 ` Mitch Bradley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54D6F5.8050805@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox