From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] pinctrl: support pinconfig on the U300
Date: Wed, 07 Mar 2012 15:40:18 -0700 [thread overview]
Message-ID: <4F57E3D2.40405@wwwdotorg.org> (raw)
In-Reply-To: <1331071533-24789-1-git-send-email-linus.walleij@stericsson.com>
On 03/06/2012 03:05 PM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro•org>
>
> This adds pin configuration support for the U300 driver pair,
> we can now read out the biasing and drive mode in debugfs and
> configure it using the new configuration API.
> +int u300_pin_config_set(struct pinctrl_dev *pctldev,
> + unsigned pin,
> + unsigned long config)
> +{
> + struct pinctrl_gpio_range *range = u300_match_gpio_range(pin);
> + int ret;
> +
> + if (!range)
> + return -EINVAL;
> +
> + /* Note: none of these configurations take any argument */
> + ret = u300_gpio_config_set(range->gc,
> + (pin - range->pin_base + range->base),
> + to_config_param(config));
I'm a little confused here; the documentation for most of the
PIN_CONFIG_* parameters that this function is passed does explicitly
document that there is an associated argument value. For example,
IN_CONFIG_BIAS_PULL_UP is coupled with the pull up resistance in Ohms.
Shouldn't this code extract the argument and validate that it's a
supported value for the HW?
next prev parent reply other threads:[~2012-03-07 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 22:05 [PATCH 3/4] pinctrl: support pinconfig on the U300 Linus Walleij
2012-03-07 22:40 ` Stephen Warren [this message]
2012-03-12 12:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F57E3D2.40405@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox