Subject: [PATCH RESEND v3] USB: Support for LPC32xx SoC

From: [email-masked] (Roland Stigge)
Date: Thu, 08 Mar 2012 23:01:00 +0100

On 08/03/12 22:11, Greg Kroah-Hartman wrote:
>> -	pnx4008_unset_usb_bits();
>> +	if (machine_is_pnx4008())
>> +		pnx4008_unset_usb_bits();
> 
> How come some of these pnx4008_* functions you have wrapped in
> machine_is_pnx4008(), but not all of them?
> 
> Actually, why don't those functions do that kind of checking themselves,
> without having to do this before you call them each time?

Good idea, I moved the machine dependent execution of the bits()
functions into the functions.

The dependency is only in the bits functions because those are done via
interfaces not available on LPC. The other pnx4008 functions seem to be
mostly compatible.

Thanks for your notes!

Roland