From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 12/12] ARM: dts: add initial dts file for EXYNOS5250, SMDK5250
Date: Tue, 13 Mar 2012 23:43:57 -0700 [thread overview]
Message-ID: <4F603E2D.1050007@samsung.com> (raw)
In-Reply-To: <20120314035655.GB2531@quad.lixom.net>
On 03/13/12 20:56, Olof Johansson wrote:
> On Tue, Mar 13, 2012 at 08:30:43AM -0700, Kukjin Kim wrote:
>> This patch adds initial dts file for EXYNOS5250 SoC. This dts
>> file is including the SoC specific devices and properties. And
>> adds the dts file for SMDK5250 board which uses the EXYNOS5250
>> dts file. Its board specific properites will be added later.
>>
>> Cc: Thomas Abraham<thomas.abraham@linaro•org>
>> Cc: Grant Likely<grant.likely@secretlab•ca>
>> Signed-off-by: Kukjin Kim<kgene.kim@samsung•com>
>> ---
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 26 ++
>> arch/arm/boot/dts/exynos5250.dtsi | 413 +++++++++++++++++++++++++++++
>> 2 files changed, 439 insertions(+), 0 deletions(-)
>> create mode 100644 arch/arm/boot/dts/exynos5250-smdk5250.dts
>> create mode 100644 arch/arm/boot/dts/exynos5250.dtsi
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> new file mode 100644
>> index 0000000..491539a
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
[...]
>> + chosen {
>> + bootargs = "root=/dev/ram0 rw ramdisk=8192 rootfstype=squashfs initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc";
>
> Having these specific bootargs in the include file rarely makes sense, it's
> better to have firmware update from the settings in firmware and just have a very
> simple fallback here.
>
> In particular initrd is quite custom to hardcode like that.
>
Yes, the bootargs is no mandatory in dts file and u-boot bootargs can be
set. OK, we can simplify it here like following.
bootargs = "root=/dev/ram0 rw ramdisk=8192 console=ttySAC1,115200"
[...]
>> + watchdog at 101D0000 {
>
> lowercase hex here and elsewhere in these files, please.
>
OK, I see.
> Also, technically no need to specify a unit address (@<foo>) in the device node
> name unless you need it to tell more than one entry apart, but it's become
> customary to always add them on ARM for some reason.
>
OK, just to be consistent in writing device nodes, prefer to add address
to the names for all device nodes.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-03-14 6:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 15:30 [PATCH v3 00/12] ARM: EXYNOS: add support new EXYNOS5250 Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 01/12] ARM: EXYNOS: to declare static for mach-exynos/common.c Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 02/12] ARM: EXYNOS: use exynos_init_uarts() instead of exynos4_init_uarts() Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 03/12] ARM: EXYNOS: add clock part for EXYNOS5250 SoC Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 04/12] ARM: EXYNOS: add initial setup-i2c0 for EXYNOS5 Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 05/12] ARM: EXYNOS: add support uart for EXYNOS4 and EXYNOS5 Kukjin Kim
2012-03-13 16:13 ` Arnd Bergmann
2012-03-14 7:06 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 06/12] ARM: EXYNOS: add support for EXYNOS5250 SoC Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 07/12] ARM: EXYNOS: add interrupt definitions for EXYNOS5250 Kukjin Kim
2012-03-14 3:42 ` Olof Johansson
2012-03-14 6:30 ` Kukjin Kim
2012-03-14 5:27 ` Thomas Abraham
2012-03-14 6:32 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 08/12] ARM: EXYNOS: support EINT for EXYNOS4 and EXYNOS5 Kukjin Kim
2012-03-14 3:52 ` Olof Johansson
2012-03-14 6:33 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 09/12] ARM: EXYNOS: add support get_core_count() for EXYNOS5250 Kukjin Kim
2012-03-13 16:15 ` Arnd Bergmann
2012-03-14 6:49 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 10/12] ARM: EXYNOS: add support ARCH_EXYNOS5 for EXYNOS5 SoCs Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 11/12] ARM: EXYNOS: add support device tree enabled board file for EXYNOS5 Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 12/12] ARM: dts: add initial dts file for EXYNOS5250, SMDK5250 Kukjin Kim
2012-03-14 3:56 ` Olof Johansson
2012-03-14 6:43 ` Kukjin Kim [this message]
2012-03-13 16:22 ` [PATCH v3 00/12] ARM: EXYNOS: add support new EXYNOS5250 Arnd Bergmann
2012-03-14 3:57 ` Olof Johansson
2012-03-14 7:08 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F603E2D.1050007@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox