From: viresh.kumar@st•com (Viresh Kumar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: SPEAr600: Add device-tree support to SPEAr600 boards
Date: Thu, 15 Mar 2012 13:49:54 +0530 [thread overview]
Message-ID: <4F61A62A.3040501@st.com> (raw)
In-Reply-To: <1331737232-25477-1-git-send-email-sr@denx.de>
Hi Stefan,
Thanks for your patch. :)
I have looked carefully at the patch, regarding addresses and irq numbers,
and they look fine. Just few minor comments below:
On 3/14/2012 8:30 PM, Stefan Roese wrote:
> diff --git a/arch/arm/boot/dts/spear600.dtsi b/arch/arm/boot/dts/spear600.dtsi
> + soc {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "simple-bus";
> + ranges;
> +
> +
> + gmac0: ethernet at e0800000 {
There is no gmac1, so can name it gmac only.
> + compatible = "st,spear600-gmac";
> + reg = <0xe0800000 0x8000>;
> + interrupt-parent = <&vic1>;
> + interrupts = <24 23>;
> + interrupt-names = "macirq", "eth_wake_irq";
> + mac-address = [000000000000]; /* Filled in by U-Boot */
> + };
> +
> + fsmc0: flash at d1800000 {
same.
> + status = "disabled";
> + compatible = "st,spear600-fsmc-nand";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0xd1800000 0x1000 /* FSMC Register */
> + 0xd2000000 0x4000>; /* NAND Base */
> + reg-names = "fsmc_regs", "nand_data";
> + };
> +
> + smi0: flash at fc000000 {
same
> + status = "disabled";
> + compatible = "st,spear600-smi";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0xfc000000 0x1000>;
> + interrupt-parent = <&vic1>;
> + interrupts = <12>;
> + };
> +
> diff --git a/arch/arm/mach-spear6xx/spear600_evb.c b/arch/arm/mach-spear6xx/spear600_evb.c
> index c6e4254..c4949aa 100644
> --- a/arch/arm/mach-spear6xx/spear600_evb.c
> +++ b/arch/arm/mach-spear6xx/spear600_evb.c
> @@ -32,9 +32,6 @@ static void __init spear600_evb_init(void)
> {
> unsigned int i;
>
Why don't we remove the devices from arrays above, which are now
supported by DT?
> - /* call spear600 machine init function */
> - spear600_init();
> -
> /* Add Platform Devices */
> platform_add_devices(plat_devs, ARRAY_SIZE(plat_devs));
>
> diff --git a/arch/arm/mach-spear6xx/spear6xx.c b/arch/arm/mach-spear6xx/spear6xx.c
> +static const struct of_device_id vic_of_match[] __initconst = {
> + { .compatible = "arm,pl190-vic", .data = vic_of_init, },
> + { /* Sentinel */ }
> +};
> +
> +static void __init spear6xx_dt_init_irq(void)
> +{
> + of_irq_init(vic_of_match);
> +}
> +
Did you checked this out?
--
viresh
next prev parent reply other threads:[~2012-03-15 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 15:00 [PATCH v2] ARM: SPEAr600: Add device-tree support to SPEAr600 boards Stefan Roese
2012-03-14 15:54 ` Arnd Bergmann
2012-03-14 16:21 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 16:49 ` Stefan Roese
2012-03-14 17:24 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 19:01 ` Stefan Roese
2012-03-15 15:32 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-15 8:19 ` Viresh Kumar [this message]
2012-03-15 8:41 ` Stefan Roese
2012-03-15 8:42 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61A62A.3040501@st.com \
--to=viresh.kumar@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox