From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] ARM: Exynos5: Fix incorrect initialization of GIC
Date: Wed, 28 Mar 2012 18:46:09 -0700 [thread overview]
Message-ID: <4F73BEE1.5050301@samsung.com> (raw)
In-Reply-To: <1332840365-24827-4-git-send-email-thomas.abraham@linaro.org>
Thomas Abraham wrote:
> Use the of_irq_init() call to setup the gic which also properly registers
> the gic device node pointer with gic irq domain, without which all interrupt
> specifier translations for gic fail.
>
> Signed-off-by: Thomas Abraham<thomas.ab@samsung•com>
> ---
> arch/arm/mach-exynos/common.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index f265dc4..3bf39a8 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -542,7 +542,7 @@ void __init exynos5_init_irq(void)
> {
> int irq;
>
> - gic_init(0, IRQ_PPI(0), S5P_VA_GIC_DIST, S5P_VA_GIC_CPU);
> + of_irq_init(exynos4_dt_irq_match);
>
> for (irq = 0; irq< EXYNOS5_MAX_COMBINER_NR; irq++) {
> combiner_init(irq, (void __iomem *)S5P_VA_COMBINER(irq),
Yes, right. The of_irq_init() shold be used instead. But I need to check
about the usage of SPI and if any updates, let you know :)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-03-29 1:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 9:26 [PATCH 0/4] ARM: Exynos: Fixes for Exynos5 device tree support Thomas Abraham
2012-03-27 9:26 ` [PATCH 1/4] ARM: Exynos: Use CHIP_ID to detect cpu type during decompression setup Thomas Abraham
2012-03-29 1:34 ` Kukjin Kim
2012-03-27 9:26 ` [PATCH 2/4] ARM: Exynos: Remove a new bus_type instance for Exynos5 Thomas Abraham
2012-03-27 9:26 ` [PATCH 3/4] ARM: Exynos5: Fix incorrect initialization of GIC Thomas Abraham
2012-03-29 1:46 ` Kukjin Kim [this message]
2012-03-27 9:26 ` [PATCH 4/4] ARM: Exynos5: Add PDMA and MDMA physical base address defines Thomas Abraham
2012-03-29 1:54 ` Kukjin Kim
2012-04-09 3:48 ` Olof Johansson
2012-04-10 16:56 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F73BEE1.5050301@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox