public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: stigge@antcom•de (Roland Stigge)
To: linux-arm-kernel@lists•infradead.org
Subject: GPIO range check in drivers/of/gpio.c
Date: Tue, 03 Apr 2012 10:32:16 +0200	[thread overview]
Message-ID: <4F7AB590.2090505@antcom.de> (raw)

Hi,

I'm wondering about a range check in drivers/of/gpio.c:144:

> int of_gpio_simple_xlate(struct gpio_chip *gc,
>			 const struct of_phandle_args *gpiospec, u32 *flags)
> {
>	/*
>	 * We're discouraging gpio_cells < 2, since that way you'll have to
>	 * write your own xlate function (that will have to retrive the GPIO
>	 * number and the flags from a single gpio cell -- this is possible,
>	 * but not recommended).
>	 */
>	if (gc->of_gpio_n_cells < 2) {
>		WARN_ON(1);
>		return -EINVAL;
>	}
>
>	if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells))
>		return -EINVAL;
>
>	if (gpiospec->args[0] > gc->ngpio)
>		return -EINVAL;

Shouldn't this be rather:

	if (gpiospec->args[0] >= gc->ngpio)

?

Thanks in advance,

Roland

next             reply	other threads:[~2012-04-03  8:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03  8:32 Roland Stigge [this message]
2012-04-03 15:37 ` GPIO range check in drivers/of/gpio.c Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7AB590.2090505@antcom.de \
    --to=stigge@antcom$(echo .)de \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox