From: stigge@antcom•de (Roland Stigge)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] gpio: Device tree support for LPC32xx
Date: Wed, 04 Apr 2012 13:08:04 +0200 [thread overview]
Message-ID: <4F7C2B94.8090601@antcom.de> (raw)
In-Reply-To: <201204040848.39376.arnd@arndb.de>
On 04/04/2012 10:48 AM, Arnd Bergmann wrote:
>> +#ifdef CONFIG_OF
>> +static struct of_device_id lpc32xx_gpio_of_match[] __devinitdata = {
>> + { .compatible = "nxp,lpc32xx-gpio", },
>> + { },
>> +};
>> +#endif
>> +
>> +static struct platform_driver lpc32xx_gpio_driver = {
>> + .driver = {
>> + .name = "lpc32xx-gpio",
>> + .owner = THIS_MODULE,
>> + .of_match_table = lpc32xx_gpio_of_match,
>> + },
>> + .probe = lpc32xx_gpio_probe,
>> +};
>
> The #ifdef above is not helpful, it will cause a build error in the
> of_match_table= assignment. Since the plan for this driver is to
> be devicetree-only, it would be appropriate to just remove the
> #ifdef, but adding of_match_ptr() is ok too.
I think I just forgot the of_match_ptr(). Will post an update with a
repo for gpio to pull from.
Thanks for the note!
Roland
next prev parent reply other threads:[~2012-04-04 11:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 23:58 [PATCH v2] gpio: Device tree support for LPC32xx Roland Stigge
2012-04-04 8:48 ` Arnd Bergmann
2012-04-04 11:08 ` Roland Stigge [this message]
2012-04-07 3:53 ` Grant Likely
2012-04-07 13:50 ` Roland Stigge
2012-04-07 14:19 ` Roland Stigge
2012-04-07 17:17 ` jonsmirl at gmail.com
2012-04-07 17:45 ` Roland Stigge
2012-04-07 18:54 ` jonsmirl at gmail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7C2B94.8090601@antcom.de \
--to=stigge@antcom$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox