Subject: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

From: [email-masked] (Jon Hunter)
Date: Wed, 4 Apr 2012 14:22:07 -0500

Hi Shubhro,

On 04/04/2012 12:45 PM, Shubhrajyoti Datta wrote:
> Hi Jon,
>
>
>>> +       if (dev->flags&    OMAP_I2C_FLAG_APPLY_ERRATA_I207)
>>>
>>> +               dev->errata |= I2C_OMAP_ERRATA_I207;
>>> +
>>>         if (dev->rev<= OMAP_I2C_REV_ON_3430_3530)
>>>                 dev->errata |= I2C_OMAP3_1P153;
>>
>>
>> The errata ID is not correct. I believe that 1P153 is referring to the
>> section number in the errata doc and not the errata ID. The errata ID should
>> be i451 in the latest OMAP34xx and OMAP36xx docs.
>>
>> Please can you update this? The section number changed in the latest errata
>> docs and it took me a minute to find this.
>
> Do you mind if that is a separate patch?

Not at all and in fact it probably should be.

Thanks
Jon