From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: Exynos4: read initial state of power domain from hw registers
Date: Fri, 06 Apr 2012 16:32:09 +0400 [thread overview]
Message-ID: <4F7EE249.30002@mvista.com> (raw)
In-Reply-To: <1333699222-16270-1-git-send-email-m.szyprowski@samsung.com>
Hello.
On 06-04-2012 12:00, Marek Szyprowski wrote:
> Some bootloadered
Bootloaders?
> disable unused power domains, so kernel code should
> read the actual state from the hardware registers instead of assuming
> that their initial state is 'on'.
> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung•com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung•com>
> ---
> arch/arm/mach-exynos/pm_domains.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
> diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
> index 13b3068..b5b92e8 100644
> --- a/arch/arm/mach-exynos/pm_domains.c
> +++ b/arch/arm/mach-exynos/pm_domains.c
> @@ -151,9 +151,11 @@ static __init int exynos4_pm_init_power_domain(void)
> if (of_have_populated_dt())
> return exynos_pm_dt_parse_domains();
>
> - for (idx = 0; idx< ARRAY_SIZE(exynos4_pm_domains); idx++)
> - pm_genpd_init(&exynos4_pm_domains[idx]->pd, NULL,
> - exynos4_pm_domains[idx]->is_off);
> + for (idx = 0; idx< ARRAY_SIZE(exynos4_pm_domains); idx++) {
> + struct exynos_pm_domain *pd = exynos4_pm_domains[idx];
> + int on = __raw_readl(pd->base + 0x4)& S5P_INT_LOCAL_PWR_EN;
Empty line wouldn't hurt here.
> + pm_genpd_init(&pd->pd, NULL, !on);
> + }
WBR, Sergei
next prev parent reply other threads:[~2012-04-06 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 8:00 [PATCH] ARM: Exynos4: read initial state of power domain from hw registers Marek Szyprowski
2012-04-06 12:32 ` Sergei Shtylyov [this message]
2012-04-10 12:39 ` [PATCH v2] " Marek Szyprowski
2012-05-10 9:09 ` Kukjin Kim
2012-05-10 12:06 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7EE249.30002@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox