From: ulf.hansson@stericsson•com (Ulf Hansson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support
Date: Fri, 13 Apr 2012 11:54:21 +0200 [thread overview]
Message-ID: <4F87F7CD.4000004@stericsson.com> (raw)
In-Reply-To: <20120413091828.GJ3168@opensource.wolfsonmicro.com>
On 04/13/2012 11:18 AM, Mark Brown wrote:
> On Fri, Apr 13, 2012 at 11:03:56AM +0200, Ulf Hansson wrote:
>
>> But, how should those amba drivers that implements runtime PM
>> support be able to switch of the vcore regulator during normal
>> suspend? In normal suspend case we can not use
>
> A generic AMBA driver should have no idea about the implementation of
> the particular SoC that it's integrated on to. This applies even more
> to system suspend (where drivers can generally just assume that they
> will loose all power normally) than it does to runtime suspend.
>
>> pm_runtime_put/pm_runtime_put_sync to trigger the power domain
>> runtime functions to switch of vcore. This is kind of more generic
>> problem when dealing with power domains, but as said this patch will
>> have consequences.
>
> The power domain gets callbacks on the system suspend path too and can
> do whatever is sensible there.
>
>> As far as I can see, the power domain must then implement a
>> suspend_noirq function to make sure same things is done as for the
>> runtime_suspend function. Do you agree with this as well or is there
>> another option?
>
> Yes, the power domain should just be handling this transparently.
Alright, thanks for your confirmation. Let's see how this works out then.
Kind regards
Ulf Hansson
prev parent reply other threads:[~2012-04-13 9:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 18:58 [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support Mark Brown
2012-04-01 19:22 ` Linus Walleij
2012-04-01 19:39 ` Rabin Vincent
2012-04-01 22:39 ` Linus Walleij
2012-04-02 10:14 ` Mark Brown
2012-04-02 10:43 ` Russell King - ARM Linux
2012-04-02 11:34 ` Mark Brown
2012-04-02 16:57 ` Russell King - ARM Linux
2012-04-02 17:19 ` Mark Brown
2012-04-02 15:52 ` Linus Walleij
2012-04-01 21:27 ` Mark Brown
2012-04-01 22:33 ` Linus Walleij
2012-04-02 10:41 ` Mark Brown
2012-04-06 7:49 ` Shawn Guo
2012-04-10 8:31 ` Russell King - ARM Linux
2012-04-10 8:35 ` Mark Brown
2012-04-10 8:47 ` Russell King - ARM Linux
2012-04-10 8:58 ` Shawn Guo
2012-04-06 18:12 ` Rob Herring
2012-04-13 9:03 ` Ulf Hansson
2012-04-13 9:18 ` Mark Brown
2012-04-13 9:54 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F87F7CD.4000004@stericsson.com \
--to=ulf.hansson@stericsson$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox