From: viresh.kumar@st•com (Viresh Kumar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 4/4] SPEAr3xx: Add pinctrl support for boards
Date: Mon, 16 Apr 2012 09:07:47 +0530 [thread overview]
Message-ID: <4F8B940B.7030700@st.com> (raw)
In-Reply-To: <4F8851E5.7050509@wwwdotorg.org>
On 4/13/2012 9:48 PM, Stephen Warren wrote:
> On 04/11/2012 11:24 PM, Viresh Kumar wrote:
>> Signed-off-by: Viresh Kumar <viresh.kumar@st•com>
>
> Just a couple of minor comments below.
No Probs.
>> diff --git a/arch/arm/boot/dts/spear300-evb.dts b/arch/arm/boot/dts/spear300-evb.dts
>
>> + pinmux at 99000000 {
>> + st,pinmux-mode=<2>;
>
> spaces around = here for consistency?
Ok.
>> + state_default: pinmux {
>> + i2c0 {
>> + st,pins = "i2c0_grp";
>> + st,function = "i2c0";
>> + };
>
> Do the group names need the "_grp" suffix? If that's what's in your TRM,
> it's fine by me, but I'd guess that isn't the case, and if so I'd say
> either drop the _grp suffix here, or enhance the binding documentation
> to mention the need to add this suffix when writing the .dts file.
Updated Documentation clearly for this.
As you have spent a lot of time getting these reviewed, i would add your
Reviewed-by on all these patches. Hope that would be fine?
Will fix all these, resend them and send a pull request to Arnd.
--
viresh
next prev parent reply other threads:[~2012-04-16 3:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 5:24 [PATCH V3 0/4] pinctrl: Add SPEAr pinctrl support Viresh Kumar
2012-04-12 5:24 ` [PATCH V3 1/4] SPEAr: Remove existing padmux support for SPEAr Viresh Kumar
2012-04-13 13:00 ` Linus Walleij
2012-04-12 5:24 ` [PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers Viresh Kumar
2012-04-13 13:01 ` Linus Walleij
2012-04-13 16:08 ` Stephen Warren
2012-04-16 3:35 ` Viresh Kumar
2012-04-12 5:24 ` [PATCH V3 4/4] SPEAr3xx: Add pinctrl support for boards Viresh Kumar
2012-04-13 13:05 ` Linus Walleij
2012-04-13 16:18 ` Stephen Warren
2012-04-16 3:37 ` Viresh Kumar [this message]
2012-04-16 18:05 ` Stephen Warren
[not found] ` <61fe5fe87fdddfc66d21d82b1039de3782b50201.1334207964.git.viresh.kumar@st.com>
2012-04-13 13:04 ` [PATCH V3 3/4] pinctrl: Add SPEAr3xx pinctrl drivers Linus Walleij
2012-04-13 16:13 ` Stephen Warren
2012-04-16 3:35 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8B940B.7030700@st.com \
--to=viresh.kumar@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox