From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 04/12] ARM: Exynos5: Remove duplicated instantiation of pdma clock
Date: Wed, 18 Apr 2012 17:30:46 -0700 [thread overview]
Message-ID: <4F8F5CB6.4080505@samsung.com> (raw)
In-Reply-To: <1334641595-25301-5-git-send-email-thomas.abraham@linaro.org>
Thomas Abraham wrote:
> The clock of both the peripheral dma controllers is controlled by a single
> clock gate. Hence remove the duplicate instantiation of the pdma clock.
>
> Signed-off-by: Thomas Abraham<thomas.abraham@linaro•org>
> ---
> arch/arm/mach-exynos/clock-exynos5.c | 17 ++++-------------
> 1 files changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
> index 662615d..fb95e9b 100644
> --- a/arch/arm/mach-exynos/clock-exynos5.c
> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> @@ -762,16 +762,8 @@ static struct clk exynos5_init_clocks_on[] = {
> }
> };
>
> -static struct clk exynos5_clk_pdma0 = {
> +static struct clk exynos5_clk_pdma = {
> .name = "dma",
> - .devname = "dma-pl330.0",
> - .enable = exynos5_clk_ip_fsys_ctrl,
> - .ctrlbit = (1<< 1),
> -};
> -
> -static struct clk exynos5_clk_pdma1 = {
> - .name = "dma",
> - .devname = "dma-pl330.1",
> .enable = exynos5_clk_ip_fsys_ctrl,
> .ctrlbit = (1<< 1),
Since this shuld be (1 << 2), this patch can be dropped.
As I know, Boojin's patch fixes this. If not, please fix this :)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-04-19 0:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 5:46 [PATCH 00/12] Updates for Exynos5250 Rev1.0 and device tree support Thomas Abraham
2012-04-17 5:46 ` [PATCH 01/12] ARM: Exynos: Remove a new bus_type instance for Exynos5 Thomas Abraham
2012-04-19 0:15 ` Kukjin Kim
2012-04-17 5:46 ` [PATCH 02/12] ARM: Exynos5: Fix incorrect initialization of GIC Thomas Abraham
2012-04-19 0:51 ` Kukjin Kim
2012-04-17 5:46 ` [PATCH 03/12] ARM: Exynos5: Add watchdog timer clock instance Thomas Abraham
2012-04-17 6:14 ` Kyungmin Park
2012-04-17 8:12 ` Thomas Abraham
2012-04-19 0:28 ` Kukjin Kim
2012-04-17 5:46 ` [PATCH 04/12] ARM: Exynos5: Remove duplicated instantiation of pdma clock Thomas Abraham
2012-04-19 0:30 ` Kukjin Kim [this message]
2012-04-17 5:46 ` [PATCH 05/12] ARM: Exynos5: Add MDMA0 clock instance Thomas Abraham
2012-04-19 1:20 ` Kukjin Kim
2012-04-17 5:46 ` [PATCH 06/12] rtc-s3c: Fix breakage introduced by S3C2443/S3C2416 support Thomas Abraham
2012-04-17 6:30 ` Kyungmin Park
2012-04-17 8:15 ` Thomas Abraham
2012-04-17 8:25 ` Kyungmin Park
2012-04-17 8:39 ` Thomas Abraham
2012-04-17 5:46 ` [PATCH 07/12] ARM: Exynos5: Modify the GIC physical address for static io-mapping Thomas Abraham
2012-04-17 6:31 ` Kyungmin Park
2012-04-17 8:19 ` Thomas Abraham
2012-04-17 5:46 ` [PATCH 08/12] gpio/samsung: add GPC4 bank instance Thomas Abraham
2012-04-17 6:33 ` Kyungmin Park
2012-04-17 8:24 ` Thomas Abraham
2012-04-19 0:36 ` Kukjin Kim
2012-04-17 5:46 ` [PATCH 09/12] ARM: Exynos5: Add pre-divider and fout mux clocks for bpll and mpll Thomas Abraham
2012-04-17 5:46 ` [PATCH 10/12] ARM: Exynos: Redefine IRQ_MCT_L0,1 definition Thomas Abraham
2012-04-19 1:00 ` Kukjin Kim
2012-04-17 5:46 ` [PATCH 11/12] ARM: Exynos5: Update device tree source files Thomas Abraham
2012-04-17 5:46 ` [PATCH 12/12] ARM: Exynos5: Update device tree enabled machine file Thomas Abraham
2012-04-19 0:23 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F5CB6.4080505@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox