From: viresh.kumar@st•com (Viresh Kumar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 02/40] clk: add a fixed factor clock
Date: Thu, 19 Apr 2012 11:49:31 +0530 [thread overview]
Message-ID: <4F8FAE73.9040900@st.com> (raw)
In-Reply-To: <20120419061620.GA2790@glitch>
On 4/19/2012 11:46 AM, Domenico Andreoli wrote:
> On Thu, Apr 19, 2012 at 09:18:01AM +0530, Viresh Kumar wrote:
>> On 4/10/2012 7:15 PM, Sascha Hauer wrote:
>> diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
>> @@ -16,7 +16,6 @@ struct clk_fixed_factor {
>> struct clk_hw hw;
>> unsigned int mult;
>> unsigned int div;
>> - char *parent[1];
>
> add const here
>
I removed it. :)
>> clk = clk_register(dev, name,
>> &clk_fixed_factor_ops, &fix->hw,
>> - fix->parent,
>> + &parent_name,
>
> &parent_name is a pointer to a stack variable, right? clk_register
> saves it in the clk struct for later use, when the stack is already gone.
Yes. It is on stack, but clk_register doesn't save it any more. Following is
part of clk_register that saves
/* copy each string name in case parent_names is __initdata */
for (i = 0; i < num_parents; i++) {
clk->parent_names[i] = kstrdup(parent_names[i], GFP_KERNEL);
if (!clk->parent_names[i]) {
pr_err("%s: could not copy parent_names\n", __func__);
goto fail_parent_names_copy;
}
}
This happened with following patch sent by Mike. This isn't pushed till now.
Author: Mike Turquette <mturquette@linaro•org>
Date: Thu Apr 12 09:02:50 2012 +0800
clk: core: copy parent_names & return error codes
This patch cleans up clk_register and solves a few bugs by teaching
clk_register and __clk_init to return error codes (instead of just NULL)
to better align with the existing clk.h api.
Along with that change this patch also introduces a new behavior whereby
clk_register copies the parent_names array, thus allowing platforms to
declare their parent_names arrays as __initdata.
--
Viresh
next prev parent reply other threads:[~2012-04-19 6:19 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 13:45 Convert i.MX architecture to generic clock framework Sascha Hauer
2012-04-10 13:45 ` [PATCH 01/40] clkdev: add clkname to struct clk_lookup Sascha Hauer
2012-04-10 14:30 ` Russell King - ARM Linux
2012-04-10 16:11 ` Sascha Hauer
2012-04-11 1:11 ` Richard Zhao
2012-04-11 8:24 ` Mark Brown
2012-04-11 8:45 ` Richard Zhao
2012-04-11 9:15 ` Mark Brown
2012-04-11 9:21 ` Russell King - ARM Linux
2012-04-11 9:32 ` Mark Brown
2012-04-11 9:41 ` Russell King - ARM Linux
2012-04-11 10:31 ` Mark Brown
2012-04-11 11:43 ` Russell King - ARM Linux
2012-04-12 16:33 ` Mark Brown
2012-04-11 9:20 ` Russell King - ARM Linux
2012-04-11 9:42 ` Sascha Hauer
2012-04-11 9:47 ` Russell King - ARM Linux
2012-04-13 3:33 ` Viresh Kumar
2012-04-13 4:17 ` Shawn Guo
2012-04-13 5:06 ` Viresh Kumar
2012-04-13 5:22 ` Shawn Guo
2012-04-13 8:59 ` Mark Brown
2012-04-13 9:10 ` Viresh Kumar
2012-04-13 9:17 ` Richard Zhao
2012-04-13 9:26 ` Russell King - ARM Linux
2012-04-13 9:27 ` Viresh Kumar
2012-04-13 9:36 ` Russell King - ARM Linux
2012-04-13 10:02 ` Viresh Kumar
2012-04-13 10:08 ` Mark Brown
2012-04-13 10:20 ` Russell King - ARM Linux
2012-04-13 10:43 ` Viresh Kumar
2012-04-13 23:19 ` Turquette, Mike
2012-04-24 2:17 ` Richard Zhao
2012-04-10 13:45 ` [PATCH 02/40] clk: add a fixed factor clock Sascha Hauer
2012-04-17 10:15 ` Viresh Kumar
2012-04-19 3:48 ` Viresh Kumar
2012-04-19 6:16 ` Domenico Andreoli
2012-04-19 6:19 ` Viresh Kumar [this message]
2012-04-19 6:45 ` Sascha Hauer
2012-04-10 13:45 ` [PATCH 03/40] clk: declare clk_ops of basic clks in clk-provider.h Sascha Hauer
2012-04-10 13:45 ` [PATCH 04/40] dmaengine i.MX SDMA: do not depend on grouped clocks Sascha Hauer
2012-04-10 13:45 ` [PATCH 05/40] spi i.MX: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 06/40] video imxfb: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 07/40] net fec: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 08/40] mmc mxcmmc: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 09/40] mmc sdhc i.MX: " Sascha Hauer
2012-04-20 2:06 ` Richard Zhao
2012-04-20 2:42 ` Richard Zhao
2012-04-10 13:45 ` [PATCH 10/40] serial " Sascha Hauer
2012-04-10 13:45 ` [PATCH 11/40] mtd mxc_nand: prepare/unprepare clock Sascha Hauer
2012-04-10 13:45 ` [PATCH 12/40] USB ehci mxc: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 13/40] w1 i.MX: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 14/40] watchdog imx2: prepare clk before enabling it Sascha Hauer
2012-04-10 13:45 ` [PATCH 15/40] media mx3 camera: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 16/40] dmaengine i.MX ipu: clk_prepare/unprepare clock Sascha Hauer
2012-04-10 13:45 ` [PATCH 17/40] ARM i.MX5: prepare gpc_dvfs_clk Sascha Hauer
2012-04-10 13:45 ` [PATCH 18/40] ARM i.MX: prepare for common clock framework Sascha Hauer
2012-04-10 13:45 ` [PATCH 19/40] ARM i.MX timer: request correct clock Sascha Hauer
2012-04-10 13:45 ` [PATCH 20/40] ARM i.MX: Add common clock support for pllv1 Sascha Hauer
2012-04-10 13:45 ` [PATCH 21/40] ARM i.MX: Add common clock support for pllv2 Sascha Hauer
2012-04-10 13:45 ` [PATCH 22/40] ARM: imx: add common clock support for pllv3 Sascha Hauer
2012-04-10 13:45 ` [PATCH 23/40] ARM i.MX: Add common clock support for 2bit gate Sascha Hauer
2012-04-19 7:00 ` Shawn Guo
2012-04-19 7:15 ` Richard Zhao
2012-04-19 7:26 ` Lei Wen
2012-04-19 7:52 ` Domenico Andreoli
2012-04-10 13:45 ` [PATCH 24/40] ARM: imx: add common clock support for pfd Sascha Hauer
2012-04-10 13:45 ` [PATCH 25/40] ARM: imx: add common clock support for clk busy Sascha Hauer
2012-04-10 18:59 ` Stephen Boyd
2012-04-11 6:53 ` Sascha Hauer
2012-04-11 22:21 ` Stephen Boyd
2012-04-12 3:30 ` Shawn Guo
2012-04-12 1:50 ` Richard Zhao
2012-04-12 2:44 ` Shawn Guo
2012-04-13 2:09 ` [PATCH] ARM: imx: remove clk_hw from clk_busy Shawn Guo
2012-04-13 14:34 ` Sascha Hauer
2012-04-10 13:45 ` [PATCH 26/40] ARM i.MX3: Make ccm base address a variable Sascha Hauer
2012-04-10 13:45 ` [PATCH 27/40] ARM i.MX25: implement clocks using common clock framework Sascha Hauer
2012-04-10 20:10 ` Roberto Nibali
2012-04-10 20:45 ` Fabio Estevam
2012-04-11 7:01 ` Roberto Nibali
2012-04-10 13:45 ` [PATCH 28/40] ARM i.MX1: " Sascha Hauer
2012-04-16 21:07 ` Sascha Hauer
2012-04-10 13:45 ` [PATCH 29/40] ARM i.MX21: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 30/40] ARM i.MX27: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 31/40] ARM i.MX31: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 32/40] ARM i.MX5: " Sascha Hauer
2012-04-23 6:39 ` Richard Zhao
2012-04-23 6:54 ` Sascha Hauer
2012-04-23 7:28 ` Richard Zhao
2012-04-10 13:45 ` [PATCH 33/40] ARM i.MX35: " Sascha Hauer
2012-04-10 13:45 ` [PATCH 34/40] ARM: imx6: " Sascha Hauer
2012-04-18 11:33 ` Sascha Hauer
2012-04-19 13:56 ` Shawn Guo
2012-04-19 14:06 ` Sascha Hauer
2012-04-10 13:45 ` [PATCH 35/40] ARM i.MX: remove now unused old clock support Sascha Hauer
2012-04-10 13:45 ` [PATCH 36/40] ARM i.MX pllv1: move mxc_decode_pll to its only user Sascha Hauer
2012-04-10 13:45 ` [PATCH 37/40] ARM i.MX: remove unused legacy clock support Sascha Hauer
2012-04-10 13:45 ` [PATCH 38/40] USB gadget i.MX: fix clock handling Sascha Hauer
2012-04-10 13:45 ` [PATCH 39/40] USB ehci i.MX: Fix " Sascha Hauer
2012-04-10 13:45 ` [PATCH 40/40] ARM i.MX: Remove now unused struct clk argument from mxc_timer_init Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8FAE73.9040900@st.com \
--to=viresh.kumar@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox