From: devel@ayanes•com (Adrian Yanes)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] i2c-at91: fix data-loss issue
Date: Mon, 23 Apr 2012 09:24:24 +0300 [thread overview]
Message-ID: <4F94F598.1040008@ayanes.com> (raw)
In-Reply-To: <EF2E73589CA71846A15D0B2CDF79505D0905DB4657@wm021.weinmann.com>
> The latter is probably the easiest and most transparent solution.
> There is no UNRE on G45, it just pauses the clock on an underrun
> condition.
>
> So in case UNRE is set, EIO should be returned similar to the already
> handled OVRE:
>
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index a6f9e73..a84e19b 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -238,6 +238,11 @@ static int at91_do_twi_transfer(struct at91_twi_dev *dev)
> dev_err(dev->dev, "overrun while reading\n");
> return -EIO;
> }
> + if (dev->transfer_status & AT91_TWI_UNRE && dev->is_rm9200) {
> + dev_err(dev->dev, "underrun while writing\n");
> + return -EIO;
> + }
> +
> dev_dbg(dev->dev, "transfer complete\n");
>
> return 0;
Indeed, this should be added in order to catch this exception for the
AT91RM9200.
However, the main issue still there: the board is not able to deliver
data up to 2 bytes size without to run in the UNRE case.
Measuring the i2c bus, we verified that the data is not even arriving to
the data bus, i.e. either the kernel driver is too slow to handle it or
just we are missing some tweak required by the hardware
(nevertheless the datasheet does not give any clue).
Anyone with a AT91RM9200 that can test the proposed driver as well? it
will discard that is our hardware/board the issue rather than the
chipset itself.
Adrian
prev parent reply other threads:[~2012-04-23 6:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1322479017a.git.n.voss@weinmann.de>
[not found] ` <201203191534.q2JFYl1b012744@gatekeeper.vosshq.de>
2012-04-13 10:17 ` [PATCH v9 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Hubert Feurstein
2012-04-13 10:39 ` Felipe Balbi
2012-04-13 11:44 ` [PATCH] i2c-at91: fix data-loss issue Hubert Feurstein
2012-04-13 22:06 ` Ryan Mallon
2012-04-16 7:30 ` Voss, Nikolaus
2012-04-16 9:27 ` Hubert Feurstein
2012-04-18 14:39 ` Wolfram Sang
[not found] ` <4F930B77.8070909@ayanes.com>
2012-04-23 5:39 ` Voss, Nikolaus
2012-04-23 6:24 ` Adrian Yanes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F94F598.1040008@ayanes.com \
--to=devel@ayanes$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox