From: viresh.kumar@st•com (Viresh Kumar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 2/8] clk: add a fixed factor clock
Date: Thu, 3 May 2012 15:18:25 +0530 [thread overview]
Message-ID: <4FA25469.6030701@st.com> (raw)
In-Reply-To: <20120503063721.GD4141@pengutronix.de>
On 5/3/2012 12:07 PM, Sascha Hauer wrote:
> Yes, looks good.
Thanks. Here is one more to review, found after rebasing on latest
clk-next from Mike. I will send this a complete patch for fixed factor
clock separately, following is just for review.
This happened due to Saravana's patch:
---
drivers/clk/clk-fixed-factor.c | 15 +++++++++------
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 8d25c2e..0e8782b 100644
--- a/drivers/clk/clk-fixed-factor.c
+++ b/drivers/clk/clk-fixed-factor.c
@@ -66,10 +66,10 @@ struct clk *clk_register_fixed_factor(struct device *dev, const char *name,
unsigned int mult, unsigned int div)
{
struct clk_fixed_factor *fix;
+ struct clk_init_data init;
struct clk *clk;
fix = kmalloc(sizeof(*fix), GFP_KERNEL);
-
if (!fix) {
pr_err("%s: could not allocate fixed factor clk\n", __func__);
return ERR_PTR(-ENOMEM);
@@ -78,12 +78,15 @@ struct clk *clk_register_fixed_factor(struct device *dev, const char *name,
/* struct clk_fixed_factor assignments */
fix->mult = mult;
fix->div = div;
+ fix->hw.init = &init;
+
+ init.name = name;
+ init.ops = &clk_fixed_factor_ops;
+ init.flags = flags;
+ init.parent_names = &parent_name;
+ init.num_parents = 1;
- clk = clk_register(dev, name,
- &clk_fixed_factor_ops, &fix->hw,
- &parent_name,
- (parent_name ? 1 : 0),
- flags);
+ clk = clk_register(dev, &fix->hw);
if (clk)
return clk;
--
viresh
next prev parent reply other threads:[~2012-05-03 9:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 6:50 [PATCH V3 0/8] SPEAr: Move to common clock framework Viresh Kumar
2012-04-24 6:50 ` [PATCH V3 1/8] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk * Viresh Kumar
2012-04-26 7:47 ` Russell King - ARM Linux
2012-04-26 10:28 ` Viresh Kumar
2012-04-28 9:52 ` Russell King - ARM Linux
2012-04-28 11:01 ` Sascha Hauer
2012-04-28 11:06 ` Russell King - ARM Linux
2012-05-01 8:45 ` Viresh Kumar
2012-05-01 12:31 ` Shawn Guo
2012-05-02 9:54 ` Russell King - ARM Linux
2012-05-02 13:59 ` Shawn Guo
2012-05-02 14:13 ` Russell King - ARM Linux
2012-04-30 8:08 ` Viresh Kumar
2012-04-24 6:50 ` [PATCH V3 2/8] clk: add a fixed factor clock Viresh Kumar
2012-04-27 4:43 ` Viresh Kumar
2012-05-02 9:48 ` Sascha Hauer
2012-05-02 11:56 ` Viresh Kumar
2012-05-02 22:41 ` Mike Turquette
2012-05-02 22:44 ` Mike Turquette
2012-05-02 23:31 ` Russell King - ARM Linux
2012-05-03 5:32 ` Viresh Kumar
2012-05-03 6:37 ` Sascha Hauer
2012-05-03 9:48 ` Viresh Kumar [this message]
2012-04-24 6:50 ` [PATCH V3 3/8] SPEAr: clk: Add VCO-PLL Synthesizer clock Viresh Kumar
2012-04-27 4:44 ` Viresh Kumar
2012-05-03 5:47 ` Viresh Kumar
2012-05-03 9:49 ` Viresh Kumar
2012-04-24 6:50 ` [PATCH V3 4/8] SPEAr: clk: Add Auxiliary " Viresh Kumar
2012-04-27 4:45 ` Viresh Kumar
2012-05-03 5:47 ` Viresh Kumar
2012-05-03 9:50 ` Viresh Kumar
2012-04-24 6:50 ` [PATCH V3 5/8] SPEAr: clk: Add Fractional " Viresh Kumar
2012-04-27 4:45 ` Viresh Kumar
2012-05-03 5:46 ` Viresh Kumar
2012-05-03 9:51 ` Viresh Kumar
2012-04-24 6:50 ` [PATCH V3 6/8] SPEAr: clk: Add General Purpose Timer " Viresh Kumar
2012-04-27 4:46 ` Viresh Kumar
2012-05-03 5:43 ` Viresh Kumar
2012-05-03 9:51 ` Viresh Kumar
2012-04-24 6:50 ` [PATCH V3 7/8] SPEAr: Call clk_prepare() before calling clk_enable Viresh Kumar
2012-04-27 4:42 ` [PATCH V3 0/8] SPEAr: Move to common clock framework Viresh Kumar
2012-04-27 17:50 ` Turquette, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA25469.6030701@st.com \
--to=viresh.kumar@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox