From: viresh.kumar@st•com (Viresh Kumar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 4/5] pinctrl: SPEAr: Add gpio ranges support
Date: Fri, 4 May 2012 11:21:42 +0530 [thread overview]
Message-ID: <4FA36E6E.3060800@st.com> (raw)
In-Reply-To: <2b4c7e15add17a63aeab924b5b5dc2d6fadfd259.1336039716.git.viresh.kumar@st.com>
On 5/3/2012 3:42 PM, Viresh KUMAR wrote:
> +static int gpio_request_endisable(struct pinctrl_dev *pctldev,
> + struct pinctrl_gpio_range *range, unsigned offset, bool enable)
> +{
> + struct spear_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
> + struct spear_gpio_pingroup *gpio_pingroup;
> +
> + gpio_pingroup = get_gpio_pingroup(pmx, offset);
> + if (PTR_ERR(gpio_pingroup))
> + return PTR_ERR(gpio_pingroup);
> +
Minor fixup:
---
drivers/pinctrl/spear/pinctrl-spear.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/spear/pinctrl-spear.c b/drivers/pinctrl/spear/pinctrl-spear.c
index 2596fa6..c0c3b28 100644
--- a/drivers/pinctrl/spear/pinctrl-spear.c
+++ b/drivers/pinctrl/spear/pinctrl-spear.c
@@ -316,7 +316,7 @@ static int gpio_request_endisable(struct pinctrl_dev *pctldev,
struct spear_gpio_pingroup *gpio_pingroup;
gpio_pingroup = get_gpio_pingroup(pmx, offset);
- if (PTR_ERR(gpio_pingroup))
+ if (IS_ERR(gpio_pingroup))
return PTR_ERR(gpio_pingroup);
if (gpio_pingroup) {
--
viresh
next prev parent reply other threads:[~2012-05-04 5:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 10:12 [PATCH V2 0/5] pinctrl: SPEAr Updates Viresh Kumar
2012-05-03 10:12 ` [PATCH V2 1/5] pinctrl: SPEAr: Don't set all non muxreg bits on pinctrl_disable Viresh Kumar
2012-05-03 10:12 ` [PATCH V2 2/5] pinctrl: SPEAr1310: Fix pin numbers for clcd_high_res Viresh Kumar
2012-05-03 10:12 ` [PATCH V2 3/5] pinctrl: SPEAr: Add plgpio driver Viresh Kumar
2012-05-03 10:12 ` [PATCH V2 4/5] pinctrl: SPEAr: Add gpio ranges support Viresh Kumar
2012-05-04 5:51 ` Viresh Kumar [this message]
2012-05-03 10:12 ` [PATCH V2 5/5] SPEAr: Add plgpio node in device tree dtsi files Viresh Kumar
2012-05-07 13:11 ` [PATCH V2 0/5] pinctrl: SPEAr Updates Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2012-10-27 9:51 [PATCH V2 0/5] Pinctrl: SPEAr: Add support for plgpio driver Viresh Kumar
2012-10-27 9:51 ` [PATCH V2 4/5] pinctrl: SPEAr: Add gpio ranges support Viresh Kumar
2012-11-06 8:09 ` Linus Walleij
2012-11-06 8:11 ` Viresh Kumar
2012-11-06 8:27 ` Linus Walleij
2012-11-11 18:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA36E6E.3060800@st.com \
--to=viresh.kumar@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox