From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB
Date: Fri, 04 May 2012 10:51:42 -0600 [thread overview]
Message-ID: <4FA4091E.60508@wwwdotorg.org> (raw)
In-Reply-To: <20120504.093358.2098007825524274078.hdoyu@nvidia.com>
On 05/04/2012 12:33 AM, Hiroshi Doyu wrote:
> Stephen Warren wrote at Thu, 3 May 2012 19:48:25 +0200:
>> On 05/03/2012 10:05 AM, Hiroshi DOYU wrote:
>>> Use "tegra_ahb_enable_smmu()" to inform AHB that SMMU is
>>> ready, instead of directly aceessing AHB registers.
...
>>> @@ -911,14 +899,16 @@ static int tegra_smmu_probe(struct platform_device *pdev)
>>
>>> + smmu->ahb = of_parse_phandle(pdev->dev.of_node, "ahb", 0);
>>
>> Hmm, "ahb" should probably be "nvidia,ahb".
>
> Does this mean the following in dts?
>
> ahb: ahb at 6000c004 {
> compatible = "nvidia,tegra30-ahb";
> reg = <0x6000c004 0x14c>; /* AHB Arbitration + Gizmo Controller */
> };
>
> smmu: smmu at 7000f000 {
> nvidia,ahb = &ahb;
> }; ^^^^^^^^^^
>
Yes.
next prev parent reply other threads:[~2012-05-04 16:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 16:05 [PATCHv3 1/4] ARM: tegra: Add Tegra AHB driver Hiroshi DOYU
2012-05-03 16:05 ` [PATCHv3 2/4] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-05-03 17:43 ` Stephen Warren
2012-05-03 16:05 ` [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB Hiroshi DOYU
2012-05-03 17:48 ` Stephen Warren
2012-05-03 17:54 ` Hiroshi Doyu
2012-05-03 17:58 ` Stephen Warren
2012-05-04 6:36 ` Hiroshi Doyu
2012-05-04 6:33 ` Hiroshi Doyu
2012-05-04 16:51 ` Stephen Warren [this message]
2012-05-03 16:05 ` [PATCHv3 4/4] ARM: dt: tegra: Add device tree support for AHB Hiroshi DOYU
2012-05-03 17:50 ` Stephen Warren
2012-05-03 17:41 ` [PATCHv3 1/4] ARM: tegra: Add Tegra AHB driver Stephen Warren
2012-05-04 6:17 ` Hiroshi Doyu
2012-05-04 16:48 ` Stephen Warren
2012-05-07 6:06 ` Hiroshi Doyu
2012-05-03 17:59 ` Stephen Warren
2012-05-04 6:40 ` Hiroshi Doyu
2012-05-04 8:40 ` Arnd Bergmann
2012-05-04 16:50 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA4091E.60508@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox