From: jdzheng@broadcom•com (Jiandong Zheng)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: BCMRING: Fix UART declaration and clk dev name mismatch
Date: Mon, 7 May 2012 16:14:06 -0700 [thread overview]
Message-ID: <4FA8573E.4090700@broadcom.com> (raw)
In-Reply-To: <20120507230016.GA19320@windriver.com>
On 07/05/12 16:00, Paul Gortmaker wrote:
> [Re: [PATCH] ARM: BCMRING: Fix UART declaration and clk dev name mismatch] On 07/05/2012 (Mon 14:50) Jiandong Zheng wrote:
>
>> On 5/7/2012 2:39 PM, Paul Gortmaker wrote:
>>> Do things work if you simply do a partial revert of 888073d41 ?
>>>
>>> Meaning:
>>>
>>> -static AMBA_APB_DEVICE(uartA, "uartA", 0, MM_ADDR_IO_UARTA, {IRQ_UARTA}, NULL);
>>> -static AMBA_APB_DEVICE(uartB, "uartB", 0, MM_ADDR_IO_UARTB, {IRQ_UARTB}, NULL);
>>> +static AMBA_APB_DEVICE(uartA, "uarta", 0, MM_ADDR_IO_UARTA, {IRQ_UARTA}, NULL);
>>> +static AMBA_APB_DEVICE(uartB, "uartb", 0, MM_ADDR_IO_UARTB, {IRQ_UARTB}, NULL);
>>>
>>> The original error messages led me to believe it was two errors;
>>> i.e. (1) the wrong # of args error, and (2) the "a" vs. "A" error. But
>>> I think Olof was right on his 1st instinct, that it was just the
>>> single error, and the a<---> A thing was a side effect.
>>>
>>> In which case the above should just work, and it will also keep
>>> the naming consistent with what it was before any of these
>>> commits.
>> Yes. Either way works. Just in original code, the name uartA and
>> the name string "uarta" looks confusing and easy to get it wrong.
> Agreed, as it confused me as well. But I don't want to break any
> existing userspace. So if people expect the name "uarta" and the
> name "uartb" then we really should go with that. But I have no
> insight into the use case or userspace. So I leave that part of
> the input up to you.
I don't see user space has direct usage of these strings and the console
runs fine so that it should be safe.
Thanks,
JD
>
> Thanks,
> Paul.
>
>> Thanks,
>> JD
>>> Paul.
>>> --
>>>
>>
next prev parent reply other threads:[~2012-05-07 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 19:34 [PATCH] ARM: BCMRING: Fix UART declaration and clk dev name mismatch Jiandong Zheng
2012-05-07 21:39 ` Paul Gortmaker
2012-05-07 21:50 ` Jiandong Zheng
2012-05-07 23:00 ` Paul Gortmaker
2012-05-07 23:14 ` Jiandong Zheng [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-01 19:44 Jiandong Zheng
2012-05-02 11:48 ` Sergei Shtylyov
2012-05-02 16:22 ` Jiandong Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA8573E.4090700@broadcom.com \
--to=jdzheng@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox