From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE
Date: Tue, 08 May 2012 09:43:34 +0200 [thread overview]
Message-ID: <4FA8CEA6.3000008@samsung.com> (raw)
In-Reply-To: <4FA8CCC9.9030601@samsung.com>
On 05/08/2012 09:35 AM, Sylwester Nawrocki wrote:
> On 05/08/2012 07:42 AM, Kukjin Kim wrote:
>> Sylwester Nawrocki wrote:
>>>
>>> Add the gate clocks and register region address definition for
>>> FIMC-LITE devices available in Exynos4x12 and Exynos5 SoCs.
>>>
>> This is right description? I can't find your changes for EXYNOS4412 and
>> EXYNOS5 here. Only this is for EXYNOS4212 SoC.
>
> Sorry, I wasn't precise enough. EXYNOS4_PA_FIMC_LITE is for EXYNOS4212
> and EXYNOS4412 though. Please note it is initially needed for DT platforms,
> until we get proper clock DT bindings for EXYNOS. Is there, BTW, anyone
> known to work on converting EXYNOS to the common clock framework ?
>
> This patch was intended for EXYNOS4212/4412. AFAICS clock code in
> mach-exynos/clock-exynos4412.c is a subset of the EXYNOS4412 platform:
^^^^^^^^^^^^^^^^^^
Uh, should be clock-exynos4212.c.
> static void __init exynos4_init_clocks(int xtal)
> {
> ...
> if (soc_is_exynos4210())
> exynos4210_register_clocks();
> else if (soc_is_exynos4212() || soc_is_exynos4412())
> exynos4212_register_clocks();
>
> exynos4_register_clocks();
> ...
> }
>
> Should I resend the patch or could you remove " and Exynos5 SoCs"
> from the description ?
>
> --
>
> Regards,
> Sylwester Nawrocki
next prev parent reply other threads:[~2012-05-08 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 16:17 [PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE Sylwester Nawrocki
2012-05-08 5:42 ` Kukjin Kim
2012-05-08 7:35 ` Sylwester Nawrocki
2012-05-08 7:43 ` Sylwester Nawrocki [this message]
2012-05-10 9:56 ` Kukjin Kim
2012-05-10 10:05 ` Sylwester Nawrocki
2012-05-10 16:05 ` nop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA8CEA6.3000008@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox