From: lee.jones@linaro•org (Lee Jones)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 14/15] drivers/regulators: Enable the ab8500 for Device Tree
Date: Tue, 08 May 2012 18:00:20 +0100 [thread overview]
Message-ID: <4FA95124.5010309@linaro.org> (raw)
In-Reply-To: <20120508145758.GV15893@opensource.wolfsonmicro.com>
On 08/05/12 15:57, Mark Brown wrote:
> On Tue, May 08, 2012 at 03:54:09PM +0100, Lee Jones wrote:
>> On 08/05/12 14:34, Mark Brown wrote:
>
>>> Looking at the usage here it looks like most of this stuff shouldn't be
>>> there even with non-DT stuff, we probably don't want to add DT bindings
>>> for those bits.All the voltage setting is not at all device specific
>>> and can be done using the generic regulator bindings, the forcing on or
>>> off is similarly generic.
>
>> All the generic properties _are_ set using the generic bindings. The
>> only vendor specific values are the initialisation register values
>> referenced above. I'll see what happens when I remove those from DT.
>> I have a feeling that the regulators will just fail though.
>
> The comments in the arch/arm file indicate otherwise - they were talking
> about enabling and disabling regulators, and about setting voltages. It
> may be that the comments in the arch/arm code are inaccurate but with it
> being magic numbers you'd really hope they're accurate...
Fingers crossed. I'll let you know how I get on.
>>> While looking for the original patch I also noticed that you're not CCing
>>> the mailing list either... please always CC the subsystem mailing list
>>> on patches.
>
>> You don't appear to have one. I ran get_maintainer.pl on the patch
>> and the only ML it came up with was LKML. If you do have one, you
>> may need to update the MAINTAINERS file.
>
> LKML is the relevant list here.
Ah, okay. In retrospect I don't know why I didn't add it to be honest.
I'll endeavor to do so next time.
Kind regards,
Lee
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-05-08 17:00 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 18:23 [PATCH 00/15] DT enablement for Snowball Lee Jones
2012-05-04 18:23 ` [PATCH 01/15] i2c/busses: Add Device Tree support to the Nomadik I2C driver Lee Jones
2012-05-04 20:02 ` Arnd Bergmann
2012-05-04 21:27 ` Lee Jones
2012-05-05 6:17 ` Lee Jones
2012-05-09 8:42 ` Linus Walleij
2012-05-04 18:23 ` [PATCH 02/15] ARM: ux500: Remove unused i2c platform_data initialisation code Lee Jones
2012-05-09 8:46 ` Linus Walleij
2012-05-09 10:22 ` Lee Jones
2012-05-10 11:24 ` Linus Walleij
2012-05-04 18:23 ` [PATCH 03/15] ARM: ux500: Provide auxdata to be used as name base clock search for nmk-i2c Lee Jones
2012-05-09 8:48 ` Linus Walleij
2012-05-04 18:23 ` [PATCH 04/15] ARM: ux500: CONFIG: Compile in support for leds-gpio Lee Jones
2012-05-09 8:49 ` Linus Walleij
2012-05-09 10:23 ` Lee Jones
2012-05-10 11:25 ` Linus Walleij
2012-05-04 18:23 ` [PATCH 05/15] ARM: ux500: Enable the user LED on Snowball via Device Tree Lee Jones
2012-05-09 8:50 ` Linus Walleij
2012-05-04 18:23 ` [PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core Lee Jones
2012-05-04 20:25 ` Arnd Bergmann
2012-05-04 21:24 ` Lee Jones
2012-05-05 6:30 ` Lee Jones
2012-05-07 16:54 ` Mark Brown
2012-05-09 12:20 ` Linus Walleij
2012-05-14 8:41 ` Lee Jones
2012-05-14 9:11 ` Linus Walleij
2012-05-04 18:23 ` [PATCH 07/15] drivers/power: Carry out platform_data error checking on ab8500 devices Lee Jones
2012-05-09 8:51 ` Linus Walleij
2012-05-09 10:24 ` Lee Jones
2012-05-04 18:23 ` [PATCH 08/15] ARM: ux500: PRCMU related configuration and layout corrections for Device Tree Lee Jones
2012-05-09 8:53 ` Linus Walleij
2012-05-09 10:27 ` Lee Jones
2012-05-10 11:27 ` Linus Walleij
2012-05-04 18:23 ` [PATCH 09/15] drivers/mfd: Enable Device Tree support for the db8500-prcmu Lee Jones
2012-05-09 8:56 ` Linus Walleij
2012-05-09 14:30 ` Samuel Ortiz
2012-05-04 18:23 ` [PATCH 10/15] drivers/mfd: db8500-prcmu: Add support for regulator supply for nmk-i2c.4 Lee Jones
2012-05-09 8:56 ` Linus Walleij
2012-05-09 14:31 ` Samuel Ortiz
2012-05-04 18:23 ` [PATCH 11/15] drivers/mfd: Enable Device Tree for ab8500-core driver Lee Jones
2012-05-09 9:02 ` Linus Walleij
2012-05-09 10:28 ` Lee Jones
2012-05-09 11:18 ` Mark Brown
2012-05-09 11:56 ` Arnd Bergmann
2012-05-10 10:26 ` Russell King - ARM Linux
2012-05-10 12:27 ` Linus Walleij
2012-05-11 10:12 ` Samuel Ortiz
2012-05-14 8:45 ` Lee Jones
2012-05-04 18:23 ` [PATCH 12/15] drivers/regulator: ab8500: Split up probe() into manageable pieces Lee Jones
2012-05-07 16:58 ` Mark Brown
[not found] ` <CAF2Aj3h7pgh=Kbt+M5Xd_RDRbJN7K+WbaH1+8nM2Eakb1QNpsg@mail.gmail.com>
2012-05-07 18:44 ` Mark Brown
2012-05-08 11:08 ` Lee Jones
2012-05-04 18:23 ` [PATCH 13/15] ARM: ux500: Add support for ab8500 regulators into the Device Tree Lee Jones
2012-05-09 9:04 ` Linus Walleij
2012-05-04 18:23 ` [PATCH 14/15] drivers/regulators: Enable the ab8500 for " Lee Jones
2012-05-07 17:08 ` Mark Brown
2012-05-08 12:04 ` Lee Jones
2012-05-08 12:19 ` Mark Brown
2012-05-08 12:38 ` Lee Jones
2012-05-08 13:34 ` Mark Brown
2012-05-08 14:54 ` Lee Jones
2012-05-08 14:57 ` Mark Brown
2012-05-08 17:00 ` Lee Jones [this message]
2012-05-08 13:48 ` Arnd Bergmann
2012-05-08 14:29 ` Mark Brown
2012-05-08 14:36 ` Arnd Bergmann
2012-05-08 14:44 ` Mark Brown
2012-05-14 15:49 ` Lee Jones
2012-05-14 16:18 ` Arnd Bergmann
2012-05-14 17:01 ` Mark Brown
2012-05-14 15:57 ` Lee Jones
2012-05-14 16:39 ` Mark Brown
2012-05-04 18:23 ` [PATCH 15/15] ARM: ux500: Disable platform setup of the ab8500 when DT is enabled Lee Jones
2012-05-09 9:05 ` Linus Walleij
2012-05-04 20:26 ` [PATCH 00/15] DT enablement for Snowball Arnd Bergmann
[not found] <CAF2Aj3gHaha9mO4gKf0ReQc-wR7wpomf_9m59AfAUNBr2fLyCQ@mail.gmail.com>
2012-05-14 18:06 ` [PATCH 14/15] drivers/regulators: Enable the ab8500 for Device Tree Mark Brown
2012-05-14 20:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA95124.5010309@linaro.org \
--to=lee.jones@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox