From: josh.wu@atmel•com (Josh Wu)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller
Date: Thu, 17 May 2012 14:36:16 +0800 [thread overview]
Message-ID: <4FB49C60.5030002@atmel.com> (raw)
In-Reply-To: <1337161217.24809.38.camel@sauron.fi.intel.com>
Hi, Artem
On 5/16/2012 5:40 PM, Artem Bityutskiy wrote:
> On Wed, 2012-05-16 at 11:31 +0200, Lothar Wa?mann wrote:
>>>> + dev_warn(host->dev, "Only 2048 page size is currently " \
>>>> + "supported for PMECC, rolling back to Software ECC\n");
>>> Why do you use backslashes?
>>>
>> message text should not be split across lines anyway to ease grepping
>> for the message.
> I think the consensus is that it is personal decision of the author. I
> am not trying to enforce this and I also split messages. In this case I
> was only wondering why that backslash is used? I never saw this before
> in the linux kernel.
>
oh, I add the backslash only because if without it, there should be a
warning about message is splitting into two lines.
Now I think I will just keep the text message in one line. That will
avoid any warnings. thanks.
Best Regards,
Josh Wu
next prev parent reply other threads:[~2012-05-17 6:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 14:47 [PATCH v7 0/3] Add PMECC support for at91 nand flash driver Josh Wu
2012-05-15 14:47 ` [PATCH v7 1/3] MTD: at91: extract hw ecc initialization to one function Josh Wu
2012-05-15 14:47 ` [PATCH v7 2/3] MTD: add dt parameters for PMECC Josh Wu
2012-05-15 14:47 ` [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-05-16 9:25 ` Artem Bityutskiy
2012-05-16 9:31 ` Lothar Waßmann
2012-05-16 9:40 ` Artem Bityutskiy
2012-05-17 6:36 ` Josh Wu [this message]
2012-05-17 11:43 ` Artem Bityutskiy
2012-05-17 12:55 ` Russell King - ARM Linux
2012-05-18 11:54 ` Artem Bityutskiy
2012-05-16 9:17 ` [PATCH v7 0/3] Add PMECC support for at91 nand flash driver Artem Bityutskiy
2012-05-17 6:32 ` Josh Wu
2012-05-17 11:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB49C60.5030002@atmel.com \
--to=josh.wu@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox