From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/7] ARM: davinci, intc: Add irq domain support
Date: Tue, 22 May 2012 19:51:24 +0400 [thread overview]
Message-ID: <4FBBB5FC.5060901@mvista.com> (raw)
In-Reply-To: <1337694920-8925-2-git-send-email-hs@denx.de>
On 05/22/2012 05:55 PM, Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher<hs@denx•de>
> Cc: davinci-linux-open-source at linux.davincidsp.com
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: devicetree-discuss at lists.ozlabs.org
> Cc: Grant Likely<grant.likely@secretlab•ca>
> Cc: Sekhar Nori<nsekhar@ti•com>
> Cc: Wolfgang Denk<wd@denx•de>
> Cc: Sergei Shtylyov<sshtylyov@mvista•com>
In the patch subject, you'd better specify cp_intc, to avoid any confusion.
Same comment for the next patch...
> diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp_intc.c
> index f83152d..bb52807 100644
> --- a/arch/arm/mach-davinci/cp_intc.c
> +++ b/arch/arm/mach-davinci/cp_intc.c
[...]
> @@ -99,18 +101,37 @@ static struct irq_chip cp_intc_irq_chip = {
[...]
> +int __init __cp_intc_init(struct device_node *node)
> +{
> + u32 num_irq = davinci_soc_info.intc_irq_num;
> u8 *irq_prio = davinci_soc_info.intc_irq_prios;
> u32 *host_map = davinci_soc_info.intc_host_map;
> unsigned num_reg = BITS_TO_LONGS(num_irq);
> - int i;
> + int i, irq_base;
>
> davinci_intc_type = DAVINCI_INTC_TYPE_CP_INTC;
> davinci_intc_base = ioremap(davinci_soc_info.intc_base, SZ_8K);
> +
Empty line not needed.
> if (WARN_ON(!davinci_intc_base))
[...]
> @@ -165,13 +186,28 @@ void __init cp_intc_init(void)
> for (i = 0; host_map[i] != -1; i++)
> cp_intc_write(host_map[i], CP_INTC_HOST_MAP(i));
>
> - /* Set up genirq dispatching for cp_intc */
> - for (i = 0; i< num_irq; i++) {
> - irq_set_chip(i,&cp_intc_irq_chip);
> - set_irq_flags(i, IRQF_VALID | IRQF_PROBE);
> - irq_set_handler(i, handle_edge_irq);
> + irq_base = irq_alloc_descs(-1, 0, num_irq, 0);
> + if (irq_base < 0) {
> + pr_warn("Couldn't allocate IRQ numbers\n");
> + irq_base = 0;
> + }
> +
> + /* create a legacy host */
> + cp_intc_domain = irq_domain_add_legacy(node, num_irq,
> + irq_base, 0,&cp_intc_host_ops, NULL);
> +
> + if (cp_intc_domain == NULL) {
'if (!cp_int_domain)' please -- to keep the style consistent.
> + pr_err("CP INTC: failed to allocate irq host!\n");
s/CP_INTC/cp_intc/
WBR, Sergei
next prev parent reply other threads:[~2012-05-22 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 13:55 [PATCH v4 0/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 1/7] ARM: davinci, intc: Add irq domain support Heiko Schocher
2012-05-22 15:51 ` Sergei Shtylyov [this message]
2012-05-26 6:03 ` Grant Likely
2012-05-29 13:11 ` Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 2/7] ARM: davinci, intc: Add OF support for TI interrupt controller Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 3/7] ARM: davinci: configure davinci aemif chipselects through OF Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 4/7] ARM: davinci: net: davinci_emac: add OF support Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 5/7] ARM: davinci: i2c: " Heiko Schocher
2012-05-26 6:08 ` Grant Likely
2012-05-29 13:28 ` Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 6/7] ARM: mtd: nand: davinci: add OF support for davinci nand controller Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBBB5FC.5060901@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox