From: josh.wu@atmel•com (Josh Wu)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9 1/3] MTD: at91: extract hw ecc initialization to one function and use relaxed read/write
Date: Mon, 28 May 2012 16:50:50 +0800 [thread overview]
Message-ID: <4FC33C6A.4070104@atmel.com> (raw)
In-Reply-To: <1338122668.19389.4.camel@koala>
On 5/27/2012 8:44 PM, Artem Bityutskiy wrote:
> On Sat, 2012-05-26 at 21:24 +0800, Josh Wu wrote:
>> use _relaxed read/write in most place. And use writel in operations of Control Register since it needs memory barrier.
>>
>> Signed-off-by: Hong Xu<hong.xu@atmel•com>
>> Signed-off-by: Josh Wu<josh.wu@atmel•com>
> This should be split on 2 or even 3 parts:
>
> 1. You move definitions and things around.
> 2. You separate out the init stuff into a function
> 3. You start using _relaxed helpers.
>
> And you should provide better commit messages. You should explain why
> you do things - just cleanup? improvement? fix? preparation for
> something?
My goal here is to prepare for the PMECC support.
Point 1 is consistent for the later PMECC patch.
Point 2 is prepare for PMECC support.
So I think I will not add the _relaxed helpers for HW ECC operation in
this patch series. Since that is out of the goal of this patch series.
>
> I think this patch is too big, commit message is poor, patch does more
> things than documented in the commit message.
>
Indeed the commit message is poor. I will fix it.
Best Regards,
Josh Wu
next prev parent reply other threads:[~2012-05-28 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 13:24 [PATCH v9 0/3] MTD: at91: Add PMECC support for at91 nand flash driver Josh Wu
2012-05-26 13:24 ` [PATCH v9 1/3] MTD: at91: extract hw ecc initialization to one function and use relaxed read/write Josh Wu
2012-05-27 12:44 ` Artem Bityutskiy
2012-05-28 8:50 ` Josh Wu [this message]
2012-05-26 13:24 ` [PATCH v9 2/3] MTD: at91: add dt parameters for PMECC Josh Wu
2012-05-26 13:24 ` [PATCH v9 3/3] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-05-27 12:50 ` Artem Bityutskiy
2012-05-28 8:43 ` Josh Wu
2012-05-28 6:58 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 8:34 ` Josh Wu
2012-05-29 16:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28 6:39 ` [PATCH v9 0/3] MTD: at91: Add PMECC support for at91 nand flash driver Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC33C6A.4070104@atmel.com \
--to=josh.wu@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox