From: robherring2@gmail•com (Rob Herring)
To: linux-arm-kernel@lists•infradead.org
Subject: ARM Versatile defconfig PCI io out of range?
Date: Thu, 31 May 2012 08:07:22 -0500 [thread overview]
Message-ID: <4FC76D0A.9060009@gmail.com> (raw)
In-Reply-To: <201205310932.51140.arnd@arndb.de>
On 05/31/2012 04:32 AM, Arnd Bergmann wrote:
> On Wednesday 30 May 2012, Rob Herring wrote:
>> On 05/30/2012 01:02 PM, Richard Maw wrote:
>
>>>
>>> We've tried to track down the problem, but we couldn't get much further
>>> than finding out that the IO_SPACE_LIMIT in kernel/resource.c is 0xffff,
>>> which is lower than the required 0x44000000.
>>>
>>> We're not sure whether this is a problem with it not being allocated
>>> enough space, or that it is not being translated properly.
>>>
>>> Is this a known issue, I did a quick google for the "sym53c8xx
>>> can't reserve io" error, but nothing turned up.
>>> If not, does anyone have any pointers to how this could be fixed?
>>>
>>
>> I believe this is the same issue:
>>
>> http://www.gossamer-threads.com/lists/linux/kernel/1543569
>>
>> In looking at various PCI platforms and for a qemu platform with PCI to
>> test PCI changes, I had concluded (wrongly I guess) that Versatile PCI
>> was broken. This patch which has never gone upstream also played a part
>> in my conclusion:
>>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-July/021035.html
>>
>> The simple fix is to restore io.h for Versatile, but I'm looking for a
>> better way.
>
> It looks like it's a simple bug in pci.c, which puts the wrong thing into the
> pcibios_min_io variable.
>
> Does the below patch fix it?
I've resurrected your patch from ~2 years ago and that does fix it. Any
reason it was never merged? I could go with a more simple fix which just
restore IO_SPACE_LIMIT to ~0, but yours is more in the direction we want
to go with PCI mappings.
Rob
>
> Arnd
>
> diff --git a/arch/arm/mach-versatile/pci.c b/arch/arm/mach-versatile/pci.c
> index 4ae4fc8..aeb7b60 100644
> --- a/arch/arm/mach-versatile/pci.c
> +++ b/arch/arm/mach-versatile/pci.c
> @@ -305,7 +305,7 @@ int __init pci_versatile_setup(int nr, struct pci_sys_data *sys)
>
> void __init pci_versatile_preinit(void)
> {
> - pcibios_min_io = 0x44000000;
> + pcibios_min_io = 0x100;
> pcibios_min_mem = 0x50000000;
>
> __raw_writel(VERSATILE_PCI_MEM_BASE0 >> 28, PCI_IMAP0);
>
next prev parent reply other threads:[~2012-05-31 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 18:02 ARM Versatile defconfig PCI io out of range? Richard Maw
2012-05-30 19:19 ` Rob Herring
2012-05-31 9:32 ` Arnd Bergmann
2012-05-31 10:48 ` Richard Maw
2012-05-31 13:07 ` Rob Herring [this message]
2012-05-31 20:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC76D0A.9060009@gmail.com \
--to=robherring2@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox