From: tim.bird@am•sony.com (Tim Bird)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] Consolidate stack size information into THREAD_SIZE_ORDER
Date: Thu, 21 Jun 2012 10:42:17 -0700 [thread overview]
Message-ID: <4FE35CF9.60707@am.sony.com> (raw)
In-Reply-To: <4FBD8205.3010904@am.sony.com>
Any response to the following, which I submitted about
a month ago? May I submit it to the ARM patch-queue?
Note that Ben Dooks took a quick look at it, but I
haven't gotten an official ACK-ed by from anyone.
It's rather trival, has no performance impact, and
makes the code more flexible IMHO. I realize it's
not the most important issue in the world, but it
will make my life easier.
[original patch follows]
This reduces the number of magic values in the code, as well as
makes it easier to experiment with larger or smaller stack sizes.
Signed-off-by: Tim Bird <tim.bird@am•sony.com>
PATCH FOLLOWS
---
arch/arm/include/asm/thread_info.h | 2 +-
| 8 ++++----
arch/arm/mm/proc-macros.S | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/include/asm/thread_info.h b/arch/arm/include/asm/thread_info.h
index 0f04d84..5172c36 100644
--- a/arch/arm/include/asm/thread_info.h
+++ b/arch/arm/include/asm/thread_info.h
@@ -16,7 +16,7 @@
#include <asm/fpstate.h>
#define THREAD_SIZE_ORDER 1
-#define THREAD_SIZE 8192
+#define THREAD_SIZE (4096 << THREAD_SIZE_ORDER)
#define THREAD_START_SP (THREAD_SIZE - 8)
#ifndef __ASSEMBLY__
--git a/arch/arm/kernel/entry-header.S b/arch/arm/kernel/entry-header.S
index 9a8531e..f94216b 100644
--- a/arch/arm/kernel/entry-header.S
+++ b/arch/arm/kernel/entry-header.S
@@ -109,8 +109,8 @@
.endm
.macro get_thread_info, rd
- mov \rd, sp, lsr #13
- mov \rd, \rd, lsl #13
+ mov \rd, sp, lsr #12 + THREAD_SIZE_ORDER
+ mov \rd, \rd, lsl #12 + THREAD_SIZE_ORDER
.endm
@
@@ -150,8 +150,8 @@
.macro get_thread_info, rd
mov \rd, sp
- lsr \rd, \rd, #13
- mov \rd, \rd, lsl #13
+ lsr \rd, \rd, #12 + THREAD_SIZE_ORDER
+ mov \rd, \rd, lsl #12 + THREAD_SIZE_ORDER
.endm
@
diff --git a/arch/arm/mm/proc-macros.S b/arch/arm/mm/proc-macros.S
index 2d8ff3a..7006c88 100644
--- a/arch/arm/mm/proc-macros.S
+++ b/arch/arm/mm/proc-macros.S
@@ -30,8 +30,8 @@
* act_mm - get current->active_mm
*/
.macro act_mm, rd
- bic \rd, sp, #8128
- bic \rd, \rd, #63
+ mov \rd, sp, lsr #12 + THREAD_SIZE_ORDER
+ mov \rd, \rd, lsl #12 + THREAD_SIZE_ORDER
ldr \rd, [\rd, #TI_TASK]
ldr \rd, [\rd, #TSK_ACTIVE_MM]
.endm
--
1.7.9.5
next prev parent reply other threads:[~2012-06-21 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 0:34 [PATCH] Consolidate stack size information into THREAD_SIZE_ORDER Tim Bird
2012-05-24 14:19 ` Ben Dooks
2012-06-21 17:42 ` Tim Bird [this message]
2012-06-22 10:20 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE35CF9.60707@am.sony.com \
--to=tim.bird@am$(echo .)sony.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox