From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM: dt: tegra: seaboard: add regulators
Date: Mon, 25 Jun 2012 09:12:35 -0600 [thread overview]
Message-ID: <4FE87FE3.1080608@wwwdotorg.org> (raw)
In-Reply-To: <4FE80413.6070001@nvidia.com>
On 06/25/2012 12:24 AM, Laxman Dewangan wrote:
> On Saturday 23 June 2012 04:44 AM, Stephen Warren wrote:
>> From: Stephen Warren<swarren@nvidia•com>
>>
>> Seaboard uses a TPS6586x regulator. Instantiate this, and hook up a
>> couple of fixed GPIO-controlled regulators too.
>>
>> The regulator configurations were mostly taken from the ChromeOS 3.2
>> kernel. Exceptions are:
>>
>> * The schematic lists a fixed voltage for each rail, whereas the ChromeOS
>> kernel lists a range for many rails. I used the values from the
>> ChromeOS
>> kernel in all cases, since I know the board file there is the most
>> complete available for this hardware.
>>
>> * The vdd_1v2 fixed regulator is present only in the schematic. So, I
>> added
>> this based on the schematic.
>>
>> * A 3.3v fixed regulator using GPIO3 of the TPS6586x is present in the
>> ChromeOS kernel, but not in the schematic. So, I dropped this based on
>> the schematic.
>>
>> Signed-off-by: Stephen Warren<swarren@nvidia•com>
>> ---
>
> Acked-by: Laxman Dewangan <ldewangan@nvidia•com>
>
> I think this series very much depends on the series
> [PATCH V3 0/3] regulator: dt: add policy to match regulator with prop
> "regulator-compatible"
That's certainly true. However, it's a runtime dependency to enable a
new feature, and shouldn't cause any breakage without that patch, so we
don't need to be explicit about the dependency in git.
>> + regulator at 3 {
>> + reg =<3>;
>> + regulator-compatible = "ldo0";
>> + regulator-name = "vdd_ldo0";
>> + regulator-min-microvolt =<1250000>;
>> + regulator-max-microvolt =<3300000>;
>> + vin-supply =<&sm2_reg>;
>
> I think support for vin-supply is still not there for this regulator in
> driver.
That's also true. I wonder if we shouldn't support this in the regulator
core bindings instead, since the existence of a parent regulator seems
likely to be common. Either way, I'd like to include the property to
document it for now.
next prev parent reply other threads:[~2012-06-25 15:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 23:14 [PATCH 1/3] ARM: dt: tegra: seaboard: add regulators Stephen Warren
2012-06-22 23:14 ` [PATCH 2/3] ARM: dt: tegra: ventana: " Stephen Warren
2012-06-22 23:14 ` [PATCH 3/3] ARM: dt: tegra: paz00: " Stephen Warren
2012-06-23 16:35 ` Marc Dietrich
2012-06-24 11:03 ` Mark Brown
2012-06-24 12:01 ` Marc Dietrich
2012-06-24 12:31 ` Mark Brown
2012-06-24 13:27 ` Marc Dietrich
2012-06-25 8:46 ` Mark Brown
2012-06-25 10:45 ` Marc Dietrich
2012-06-25 11:07 ` Thierry Reding
2012-06-26 22:35 ` Stephen Warren
2012-06-26 23:02 ` Mark Brown
2012-06-26 23:16 ` Stephen Warren
2012-06-29 17:32 ` Stephen Warren
2012-06-30 11:45 ` Mark Brown
2012-06-25 6:24 ` [PATCH 1/3] ARM: dt: tegra: seaboard: " Laxman Dewangan
2012-06-25 15:12 ` Stephen Warren [this message]
2012-06-25 15:24 ` Laxman Dewangan
2012-06-25 15:36 ` Stephen Warren
2012-06-25 22:26 ` Mark Brown
2012-06-25 23:09 ` Stephen Warren
2012-06-26 6:38 ` Laxman Dewangan
2012-06-26 8:52 ` Mark Brown
2012-07-10 11:59 ` Laxman Dewangan
2012-07-10 13:44 ` Mark Brown
2012-07-10 13:44 ` Laxman Dewangan
2012-07-10 13:53 ` Mark Brown
2012-07-10 15:04 ` Laxman Dewangan
2012-07-10 15:42 ` Mark Brown
2012-07-10 16:39 ` Laxman Dewangan
2012-07-10 16:52 ` Mark Brown
2012-07-10 16:53 ` Laxman Dewangan
2012-07-10 17:01 ` Mark Brown
2012-07-11 10:02 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE87FE3.1080608@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox