From: jon-hunter@ti•com (Jon Hunter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration
Date: Mon, 25 Jun 2012 11:12:14 -0500 [thread overview]
Message-ID: <4FE88DDE.60601@ti.com> (raw)
In-Reply-To: <7a14edf83068261d8c07217873d14fe7f73975bc.1340354986.git.afzal@ti.com>
Hi Afzal,
Looks much better!
On 06/22/2012 04:01 AM, Afzal Mohammed wrote:
> Reorganize gpmc-onenand initialization so that changes
> required for gpmc driver migration can be made smooth.
>
> Ensuring sync read/write are disabled in onenand cannot
> be expected to work properly unless GPMC is setup, this
> has been removed.
>
> Refactor set_async_mode & set_sync_mode functions to
> separate out timing calculation & actual configuration
> (GPMC & OneNAND side).
>
> Thanks to Jon for his suggestions.
>
> Signed-off-by: Afzal Mohammed <afzal@ti•com>
> ---
>
> v4:
> Reorganize set_sync/async functions in a better way
> v3:
> Refactor set_sync/async functions to separate out timing and
> configurations
> v2:
> Move ensuring that async mode in OneNAND has been setup from
> set_sync to setup function, improve commit message
>
> arch/arm/mach-omap2/gpmc-onenand.c | 153 +++++++++++++++++++-----------------
> 1 file changed, 83 insertions(+), 70 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c
> index 8863e0a..878182b 100644
> --- a/arch/arm/mach-omap2/gpmc-onenand.c
> +++ b/arch/arm/mach-omap2/gpmc-onenand.c
> @@ -15,6 +15,7 @@
> #include <linux/platform_device.h>
> #include <linux/mtd/onenand_regs.h>
> #include <linux/io.h>
> +#include <linux/err.h>
>
> #include <asm/mach/flash.h>
>
> @@ -25,6 +26,7 @@
>
> #define ONENAND_IO_SIZE SZ_128K
>
> +static int hf, vhf, sync_read, sync_write, latency;
I am wondering if we can remove hf, vhf, sync_read/write variables
completely. We already have flags from sync_read/write and so we could
just use the cfg->flags variable and remove sync_read/write variables.
At the same time, we could create flags for ONENAND_FREQ_HF and
ONENAND_FREQ_VHF or something like that. It could be nice to store the
latency in onenand_data too. In other words, keep all the configuration
in one place.
Otherwise looks good.
Cheers
Jon
next prev parent reply other threads:[~2012-06-25 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 9:00 [PATCH v4 0/3] Prepare for GPMC driver conversion Afzal Mohammed
2012-06-22 9:00 ` [PATCH v4 1/3] ARM: OMAP2+: nand: unify init functions Afzal Mohammed
2012-06-25 15:29 ` Jon Hunter
2012-06-26 8:35 ` Mohammed, Afzal
2012-06-22 9:00 ` [PATCH v4 2/3] ARM: OMAP2+: gpmc: handle additional timings Afzal Mohammed
2012-06-22 9:01 ` [PATCH v4 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration Afzal Mohammed
2012-06-25 16:12 ` Jon Hunter [this message]
2012-06-26 8:29 ` Mohammed, Afzal
2012-06-26 14:39 ` Jon Hunter
2012-06-26 14:56 ` Jon Hunter
2012-06-27 6:53 ` Mohammed, Afzal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE88DDE.60601@ti.com \
--to=jon-hunter@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox