Subject: [PATCHv10 1/7] I2C: OMAP: I2C register restore only if context is lost

From: [email-masked] (Shubhrajyoti)
Date: Tue, 26 Jun 2012 11:38:07 +0530

On Monday 25 June 2012 06:00 PM, Felipe Balbi wrote:
>> Cc: Kevin Hilman <[email-masked]>
>> > Signed-off-by: Shubhrajyoti D <[email-masked]>
> how will this ever work with DT ? 
What you say makes sense however that is what currently
most of the omap drivers do.

Will check on this.
> I say we get rid of the OMAP-specific
> API and build this "context lost" status directly on dev_pm_info and
> have something like pm_runtime_lost_context() or something with pm QoS
> tell you if a device has lost its context.
>
> Also, your commit log doesn't really state any problems you might have
> reached before, or any improvements wrt latency coming out of suspend
> and so on.
>
> IMHO, drivers need a generic way to differentiate if they're resuming
> from OFF or RET, otherwise we will end up with a bunch of OMAP-specific
> hackery on all drivers