From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2] ARM: dt: tegra: paz00: add regulators
Date: Wed, 27 Jun 2012 12:56:01 -0600 [thread overview]
Message-ID: <4FEB5741.6020400@wwwdotorg.org> (raw)
In-Reply-To: <21985997.TUGv5fZBXQ@ax5200p>
On 06/27/2012 12:50 PM, Marc Dietrich wrote:
> On Wednesday 27 June 2012 12:31:01 Mark Brown wrote:
>> On Tue, Jun 26, 2012 at 06:31:00PM -0600, Stephen Warren wrote:
>>> sm1: HW defaults and schematic match at 1.0v. marvin24's kernel had a max
>>> of 1.125v, but this wasn't applied since apply_uV wasn't set.
>>
>> apply_uV is only valid if a single voltage is specified.
>
> yes, that's why there is a ".apply_uV = (_minmv == _maxmv)" in the regulator
> macro.
>
>> If a voltage
>> range were specified and it were acted on we'd take the lowest (not
>> highest) voltage allowed.
>
> Sorry, I don't get it. In this case, the board wouldn't boot at all because
> nearly all supplies would be undervoltaged. I just checked and all voltages
> are actually set to the *highest* (max) value. Maybe they aren't changed at
> all?
Yes, in the absence of any explicit action (i.e. a call to
regulator_set_voltage() elsewhere), the regulator core doesn't reprogram
the regulator at registration time, except for a few specific conditions
e.g. something like when min==max and apply_uV is set.
I imagine the DVFS code in your downstream kernel /is/ calling
regulator_set_voltage() later, assuming that config option is enabled
anyway. See arch/arm/mach-tegra/{dvfs.c,tegra2_dvfs.c}.
next prev parent reply other threads:[~2012-06-27 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 0:31 [PATCH V2] ARM: dt: tegra: paz00: add regulators Stephen Warren
2012-06-27 11:31 ` Mark Brown
2012-06-27 17:08 ` Stephen Warren
2012-06-27 18:50 ` Marc Dietrich
2012-06-27 18:56 ` Stephen Warren [this message]
2012-06-27 19:01 ` Marc Dietrich
2012-06-27 21:59 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEB5741.6020400@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox