From: shubhrajyoti@ti•com (Shubhrajyoti)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: OMAP2: Overo: init I2C before MMC to fix MMC suspend/resume failure
Date: Fri, 29 Jun 2012 12:03:18 +0530 [thread overview]
Message-ID: <4FED4C2E.4030309@ti.com> (raw)
In-Reply-To: <1340902892-9542-2-git-send-email-khilman@ti.com>
Hi Kevin,
On Thursday 28 June 2012 10:31 PM, Kevin Hilman wrote:
> In order for suspend/resume dependencies to work correctly, I2C has to
> be initialized (more specifically, registered with the driver core)
> before MMC.
Agree.
> Without this, the MMC driver fails to adjust the VMMC
> regulator (using i2c writes) during the suspend path.
>
> Problem found testing suspend/resume on 3730/OveroSTORM platform.
Not related to your patch.
Was just thinking if
arch/arm/mach-omap2/board-omap3beagle.c
arch/arm/mach-omap2/board-3430sdp.c
should also be patched.
> Signed-off-by: Kevin Hilman <khilman@ti•com>
> ---
> arch/arm/mach-omap2/board-overo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 8fa2fc3..779734d 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -494,8 +494,8 @@ static void __init overo_init(void)
>
> regulator_register_fixed(0, dummy_supplies, ARRAY_SIZE(dummy_supplies));
> omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
> - omap_hsmmc_init(mmc);
> overo_i2c_init();
> + omap_hsmmc_init(mmc);
> omap_display_init(&overo_dss_data);
> omap_serial_init();
> omap_sdrc_init(mt46h32m32lf6_sdrc_params,
next prev parent reply other threads:[~2012-06-29 6:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 17:01 [PATCH 0/2] ARM: OMAP: few more PM fixes for v3.5-rc Kevin Hilman
2012-06-28 17:01 ` [PATCH 1/2] ARM: OMAP2: Overo: init I2C before MMC to fix MMC suspend/resume failure Kevin Hilman
2012-06-29 6:33 ` Shubhrajyoti [this message]
2012-06-28 17:01 ` [PATCH 2/2] ARM: OMAP4: TWL6030: ensure sys_nirq1 is mux'd and wakeup enabled Kevin Hilman
2012-07-02 12:10 ` [PATCH 0/2] ARM: OMAP: few more PM fixes for v3.5-rc Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FED4C2E.4030309@ti.com \
--to=shubhrajyoti@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox