From: b-cousson@ti•com (Benoit Cousson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer
Date: Wed, 4 Jul 2012 18:57:10 +0200 [thread overview]
Message-ID: <4FF475E6.3060308@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1207040652240.6760@utopia.booyaka.com>
Hi Paul,
On 07/04/2012 02:53 PM, Paul Walmsley wrote:
> On Wed, 4 Jul 2012, Paul Walmsley wrote:
>
>> So the updated patch below uses a clockdomain data flag for this
>> instead.
>
> Here's a version that's a little cleaner. No functional changes.
[...]
> @@ -1141,8 +1144,16 @@ static void _enable_sysc(struct omap_hwmod *oh)
> sf = oh->class->sysc->sysc_flags;
>
> if (sf & SYSC_HAS_SIDLEMODE) {
> - idlemode = (oh->flags & HWMOD_SWSUP_SIDLE) ?
> - HWMOD_IDLEMODE_NO : HWMOD_IDLEMODE_SMART;
> + clkdm_act = ((oh->clkdm &&
> + oh->clkdm->flags & CLKDM_ACTIVE_WITH_MPU) ||
> + (oh->_clk->clkdm &&
This is crashing on OMAP4 due to a NULL oh->_clk that can happen on some
hwmod.
+ (oh->_clk && oh->_clk->clkdm &&
Is fixing the issue.
Regards,
Benoit
> + oh->_clk->clkdm->flags & CLKDM_ACTIVE_WITH_MPU));
> + if (clkdm_act && !(oh->class->sysc->idlemodes &
> + (SIDLE_SMART | SIDLE_SMART_WKUP)))
> + idlemode = HWMOD_IDLEMODE_FORCE;
> + else
> + idlemode = (oh->flags & HWMOD_SWSUP_SIDLE) ?
> + HWMOD_IDLEMODE_NO : HWMOD_IDLEMODE_SMART;
> _set_slave_idlemode(oh, idlemode, &v);
> }
>
next prev parent reply other threads:[~2012-07-04 16:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 0:45 [PATCHv2 00/12] ARM: OMAP: core/hwmod: first set of fixes for 3.5-rc Paul Walmsley
2012-06-11 0:45 ` [PATCHv2 01/12] ARM: OMAP: PM: Lock clocks list while generating summary Paul Walmsley
2012-06-11 0:45 ` [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer Paul Walmsley
2012-06-14 16:47 ` Cousson, Benoit
2012-06-14 18:04 ` Paul Walmsley
2012-06-14 20:13 ` Cousson, Benoit
2012-06-15 0:18 ` Paul Walmsley
2012-06-15 13:28 ` Cousson, Benoit
2012-07-04 12:48 ` Paul Walmsley
2012-07-04 12:53 ` Paul Walmsley
2012-07-04 14:27 ` Kevin Hilman
2012-07-04 14:53 ` Paul Walmsley
2012-07-04 16:14 ` Benoit Cousson
2012-07-04 16:41 ` Tero Kristo
2012-07-04 16:43 ` Benoit Cousson
2012-07-04 19:02 ` Paul Walmsley
2012-07-04 16:57 ` Benoit Cousson [this message]
2012-07-04 18:59 ` Paul Walmsley
2012-07-05 22:06 ` Kevin Hilman
2012-07-04 16:01 ` Benoit Cousson
2012-07-04 19:05 ` Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 03/12] ARM: OMAP4+: hwmod: fix issue causing IPs not going back to Smart-Standby Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 04/12] ARM: OMAP4: hwmod data: fix 32k sync timer idle modes Paul Walmsley
2012-06-11 9:31 ` Cousson, Benoit
2012-06-13 17:22 ` Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 05/12] ARM: OMAP2+: hwmod: add setup_preprogram hook Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 06/12] ARM: OMAP2+: hwmod: add flag to prevent hwmod code from touching IP block during init Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 07/12] ARM: OMAP4+: AESS: enable internal auto-gating during initial setup Paul Walmsley
2012-06-11 6:29 ` Tony Lindgren
2012-06-14 9:49 ` Paul Walmsley
2012-06-14 9:59 ` Tony Lindgren
2012-06-11 0:46 ` [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line Paul Walmsley
2012-06-14 12:55 ` Cousson, Benoit
2012-06-14 17:09 ` Paul Walmsley
2012-06-14 21:07 ` Cousson, Benoit
2012-06-14 23:02 ` Paul Walmsley
2012-06-15 9:11 ` Cousson, Benoit
2012-06-11 0:46 ` [PATCHv2 09/12] ARM: OMAP2+: usb_host_fs: add custom setup_preprogram for usb_host_fs (fsusb) Paul Walmsley
2012-06-11 6:34 ` Tony Lindgren
2012-06-11 7:13 ` Felipe Balbi
2012-06-11 7:41 ` Tony Lindgren
2012-06-11 7:48 ` Felipe Balbi
2012-06-11 8:03 ` Tony Lindgren
2012-06-11 9:12 ` Felipe Balbi
2012-06-11 0:46 ` [PATCHv2 10/12] ARM: OMAP2+: CM: increase the module disable timeout Paul Walmsley
2012-06-11 0:46 ` [PATCHv2 11/12] ARM: OMAP4: clock data: add clockdomains for clocks used as main clocks Paul Walmsley
2012-06-11 16:28 ` Cousson, Benoit
2012-06-11 16:59 ` Paul Walmsley
2012-06-11 20:15 ` Cousson, Benoit
2012-06-11 0:46 ` [PATCHv2 12/12] ARM: OMAP4: hwmod data: do not enable or reset the McPDM during kernel init Paul Walmsley
2012-06-11 9:54 ` Cousson, Benoit
2012-10-30 4:05 ` Paul Walmsley
2012-10-30 7:41 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF475E6.3060308@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox