public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@googlemail•com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers
Date: Thu, 05 Jul 2012 16:14:50 +0200	[thread overview]
Message-ID: <4FF5A15A.8070309@googlemail.com> (raw)
In-Reply-To: <20120705130819.GV17534@lunn.ch>

On 07/05/2012 03:08 PM, Andrew Lunn wrote:
> The issue is knowing what IRQ number to use for the secondary
> interrupts.
>
> Orion use generic chip interrupts, both for the main interrupts and
> the GPIO interrupts. This does not yet support irq domain, so i have
> to layer a legacy domain on top. The legacy domain needs to know the
> first IRQ and the number of IRQs. For the primary IRQs that is
> easy. However, GPIO IRQ is not so easy, it depends on how many primary
> IRQs there are. This is not fixed. Orion5x has 32, Dove 64, kirkwood,
> 64, and mv78xx0 has 96. I need to know this number when adding the
> GPIO secondary IRQ legacy domain. By calling orion_gpio_of_init() in
> the orion_add_irq_domain() i have this number to hand. If i used to
> entries in the match table, i would have to put this number into some
> global variable, or somehow ask the IRQ subsystem what the next free
> IRQ number is.

Andrew,

is it possible to group all gpio banks into one DT description?
For mach-dove it could be something like:

gpio: gpio-controller {
	compatible = "marvell, orion-gpio";
	...

	bank0 at d0400 {
		reg = <0xd0400 0x40>;
		ngpio = <8>;
		mask-offset = <0>;
		interrupts = <12>;
	};

	bank1 at d0400 {
		reg = <0xd0400 0x40>;
		ngpio = <8>;
		mask-offset = <8>;
		interrupts = <13>;
	};

	...

	bank4 at d0420 {
		reg = <0xd0420 0x40>;
		ngpio = <32>;
		interrupts = <61>;
	};		

	bank5 at e8400 {
		reg = <0xe8400 0x20>;
		ngpio = <8>;
		marvell,orion-gpio-output-only;
	};		
};

This would have the advantage that DT describes gpio-to-irq dependencies.
Moreover, nodes that reference gpios can do gpios = <&gpio 71 0>; instead of
gpios = <&gpio3 7 0>;

Sebastian

  parent reply	other threads:[~2012-07-05 14:14 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 14:22 [PATCH v2 00/12] IRQ, GPIO SPI, I2C, etc DTC support Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers Andrew Lunn
2012-07-05  8:15   ` Andrew Lunn
2012-07-05  9:02   ` Thomas Petazzoni
2012-07-05  9:48     ` Andrew Lunn
2012-07-05 10:10       ` Thomas Petazzoni
2012-07-05 10:25         ` Andrew Lunn
2012-07-05 10:11       ` Arnaud Patard (Rtp)
2012-07-05 10:20         ` Thomas Petazzoni
2012-07-05 10:38           ` Arnaud Patard (Rtp)
2012-07-05 11:42             ` Thomas Petazzoni
2012-07-05 11:48               ` Andrew Lunn
2012-07-05 12:09                 ` Sebastian Hesselbarth
2012-07-05 12:58       ` Thomas Petazzoni
2012-07-05 13:15         ` Andrew Lunn
2012-07-05 13:28           ` Thomas Petazzoni
2012-07-05 13:33             ` Andrew Lunn
2012-07-05 13:36               ` Thomas Petazzoni
2012-07-05 12:25   ` Arnd Bergmann
2012-07-05 13:08     ` Andrew Lunn
2012-07-05 13:47       ` Arnd Bergmann
2012-07-05 13:54         ` Andrew Lunn
2012-07-05 15:47           ` Arnd Bergmann
2012-07-05 14:14       ` Sebastian Hesselbarth [this message]
2012-07-05 14:43         ` Andrew Lunn
2012-07-05 14:54         ` Arnd Bergmann
2012-07-05 15:51           ` Sebastian Hesselbarth
2012-07-05 16:30             ` Arnaud Patard (Rtp)
2012-07-05 16:16           ` Andrew Lunn
2012-07-06 20:08             ` Arnd Bergmann
2012-07-06 21:00               ` Andrew Lunn
2012-07-07  0:24                 ` Where to put a large bootloader-supplied device tree on ARM ? Mitch Bradley
2012-07-07  1:23                   ` David VomLehn (dvomlehn)
2012-07-07  1:59                     ` Mitch Bradley
2012-07-09  4:30                       ` Nicolas Pitre
2012-07-12  6:52                         ` Mitch Bradley
2012-07-12 18:16                           ` Nicolas Pitre
2012-07-12 20:34                           ` Rob Herring
2012-07-12 21:38                             ` [U-Boot] " Albert ARIBAUD
2012-07-12 21:47                               ` Wolfgang Denk
2012-07-13  1:28                                 ` Rob Herring
2012-07-13  6:45                                   ` Albert ARIBAUD
2012-07-05 18:36           ` [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers Mitch Bradley
2012-07-03 14:22 ` [PATCH v2 02/12] SPI: Refactor spi-orion to use SPI framework queue Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 03/12] spi-orion: remove uneeded spi_info Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 04/12] spi-orion: add device tree binding Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 05/12] ARM: kirkwood: use devicetree for orion-spi Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 06/12] ARM: kirkwood: use devicetree for SPI on dreamplug Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 07/12] I2C: MV64XXX: Add Device Tree support Andrew Lunn
2012-07-03 15:59   ` Florian Fainelli
2012-07-03 16:58     ` Andrew Lunn
2012-07-04 19:49       ` Florian Fainelli
2012-07-05  6:52         ` Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 08/12] Kirkwood: Add basic device tree support for QNAP TS219 Andrew Lunn
2012-07-03 15:47   ` Florian Fainelli
2012-07-03 17:09     ` Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 09/12] ARM: Kirkwood: DTify the watchdog timer Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 10/12] ATA: sata_mv: Add device tree support Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 11/12] ARM: Kirkwood: Use DT to configure SATA device Andrew Lunn
2012-07-03 14:52   ` Josh Coombs
2012-07-03 15:32     ` Andrew Lunn
2012-07-03 14:22 ` [PATCH v2 12/12] Crypto: CESA: Add support for DT based instantiation Andrew Lunn
2012-07-03 15:50   ` Florian Fainelli
2012-07-03 17:03     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF5A15A.8070309@googlemail.com \
    --to=sebastian.hesselbarth@googlemail$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox