From: shinya.kuribayashi.px@renesas•com (Shinya Kuribayashi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] hwspinlock/core: add notes on lock element in 'struct hwspinlock'
Date: Fri, 06 Jul 2012 13:56:30 +0900 [thread overview]
Message-ID: <4FF66FFE.2020803@renesas.com> (raw)
In-Reply-To: <4FF66FBD.5090601@renesas.com>
'lock' must be placed at the end of struct hwspinlock_device because
we're doing 'hwlock = &bank->lock[0]' to get a pointer to the first
'struct hwspinlock' instance.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas•com>
---
drivers/hwspinlock/hwspinlock_internal.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hwspinlock/hwspinlock_internal.h b/drivers/hwspinlock/hwspinlock_internal.h
index d26f78b..c60318c 100644
--- a/drivers/hwspinlock/hwspinlock_internal.h
+++ b/drivers/hwspinlock/hwspinlock_internal.h
@@ -57,7 +57,8 @@ struct hwspinlock {
* @ops: platform-specific hwspinlock handlers
* @base_id: id index of the first lock in this device
* @num_locks: number of locks in this device
- * @lock: dynamically allocated array of 'struct hwspinlock'
+ * @lock: dynamically allocated array of 'struct hwspinlock' (must be placed
+ * at the end of the hwspinlock_device)
*/
struct hwspinlock_device {
struct device *dev;
--
1.7.11.1
next prev parent reply other threads:[~2012-07-06 4:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 4:55 [PATCH 0/3] hwspinlock: a bug fix, trivial changes Shinya Kuribayashi
2012-07-06 4:56 ` [PATCH 1/3] hwspinlock/core: use global ID to register hwspinlocks on multiple devices Shinya Kuribayashi
2012-07-07 10:49 ` Ohad Ben-Cohen
2012-07-06 4:56 ` Shinya Kuribayashi [this message]
2012-07-07 10:53 ` [PATCH 2/3] hwspinlock/core: add notes on lock element in 'struct hwspinlock' Ohad Ben-Cohen
2012-07-06 4:56 ` [PATCH 3/3] hwspinlock/core: allow hwspinlock_device to have bank-specific private data Shinya Kuribayashi
2012-07-07 10:55 ` Ohad Ben-Cohen
2012-07-07 10:59 ` [PATCH 0/3] hwspinlock: a bug fix, trivial changes Ohad Ben-Cohen
2012-07-09 0:41 ` Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF66FFE.2020803@renesas.com \
--to=shinya.kuribayashi.px@renesas$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox