public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: rnayak@ti•com (Rajendra Nayak)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data
Date: Tue, 10 Jul 2012 14:02:41 +0530	[thread overview]
Message-ID: <4FFBE8A9.6050608@ti.com> (raw)
In-Reply-To: <CAAe_U6LqF9aZLZgHQYhX6VXXB41HUNmZgXfOwe9V9VtWVe+46g@mail.gmail.com>

On Tuesday 10 July 2012 01:43 PM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Tue, Jul 10, 2012 at 11:57 AM, Rajendra Nayak<rnayak@ti•com>  wrote:
>> On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote:
>>>
>>> Add usb otg data node in omap4/omap3 device tree file. Also update
>>> the node with board specific setting in omapx-<board>.dts file.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I<kishon@ti•com>
>>> ---
>>>    arch/arm/boot/dts/omap3-beagle.dts |    6 ++++++
>>>    arch/arm/boot/dts/omap3-evm.dts    |    6 ++++++
>>>    arch/arm/boot/dts/omap3.dtsi       |    8 ++++++++
>>>    arch/arm/boot/dts/omap4-panda.dts  |    6 ++++++
>>>    arch/arm/boot/dts/omap4-sdp.dts    |    6 ++++++
>>>    arch/arm/boot/dts/omap4.dtsi       |    8 ++++++++
>>>    6 files changed, 40 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3-beagle.dts
>>> b/arch/arm/boot/dts/omap3-beagle.dts
>>> index 5b4506c..f3d7076 100644
>>> --- a/arch/arm/boot/dts/omap3-beagle.dts
>>> +++ b/arch/arm/boot/dts/omap3-beagle.dts
>>> @@ -67,3 +67,9 @@
>>>    &mmc3 {
>>>          status = "disable";
>>>    };
>>> +
>>> +&usb_otg_hs {
>>> +       interface_type =<0>;
>>> +       mode =<3>;
>>> +       power =<50>;
>>> +};
>>> diff --git a/arch/arm/boot/dts/omap3-evm.dts
>>> b/arch/arm/boot/dts/omap3-evm.dts
>>> index 2eee16e..8963b3d 100644
>>> --- a/arch/arm/boot/dts/omap3-evm.dts
>>> +++ b/arch/arm/boot/dts/omap3-evm.dts
>>> @@ -18,3 +18,9 @@
>>>                  reg =<0x80000000 0x10000000>; /* 256 MB */
>>>          };
>>>    };
>>> +
>>> +&usb_otg_hs {
>>> +       interface_type =<0>;
>>> +       mode =<3>;
>>> +       power =<50>;
>>> +};
>>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>>> index 99474fa..2f565d6 100644
>>> --- a/arch/arm/boot/dts/omap3.dtsi
>>> +++ b/arch/arm/boot/dts/omap3.dtsi
>>> @@ -215,5 +215,13 @@
>>>                          compatible = "ti,omap3-hsmmc";
>>>                          ti,hwmods = "mmc3";
>>>                  };
>>> +
>>> +               usb_otg_hs: usb_otg_hs at 4a0ab000 {
>>> +                       compatible = "ti,musb-omap2430";
>>
>>
>> this compatible doesn't seem right in omap3.dtsi. Same with
>> the below entry in omap4.dtsi.
>> See other IP blocks which are reused across OMAP2/3/4 on
>> how the compatible for those are handled.
>
> Ok. So it should be like *ti,omap4-musb*, *ti,omap3-musb*?

Yes, that would be more appropriate.

>
> Thanks
> Kishon

  reply	other threads:[~2012-07-10  8:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 11:50 [PATCH v1 00/11] omap: musb: Add device tree support Kishon Vijay Abraham I
2012-06-28 11:50 ` [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy Kishon Vijay Abraham I
2012-07-10  5:46   ` Rajendra Nayak
2012-07-10  6:03     ` Venu Byravarasu
2012-07-10  6:48       ` ABRAHAM, KISHON VIJAY
2012-07-10  7:05         ` Rajendra Nayak
2012-07-10  7:05         ` Venu Byravarasu
2012-07-10  6:37     ` ABRAHAM, KISHON VIJAY
2012-07-10  6:49       ` Rajendra Nayak
2012-06-28 11:50 ` [PATCH v1 02/11] arm/dts: omap: Add omap-usb2 dt data Kishon Vijay Abraham I
2012-06-28 11:50 ` [PATCH v1 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2 Kishon Vijay Abraham I
2012-06-28 11:51 ` [PATCH v1 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module Kishon Vijay Abraham I
2012-06-28 11:51 ` [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb Kishon Vijay Abraham I
2012-07-10  5:58   ` Rajendra Nayak
2012-07-10  6:28     ` ABRAHAM, KISHON VIJAY
2012-07-10  6:44       ` Rajendra Nayak
2012-07-10  8:18         ` ABRAHAM, KISHON VIJAY
2012-06-28 11:51 ` [PATCH v1 06/11] arm/dts: Add twl6030-usb data Kishon Vijay Abraham I
2012-06-28 11:51 ` [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb Kishon Vijay Abraham I
2012-07-10  6:02   ` Rajendra Nayak
2012-07-10  6:52     ` ABRAHAM, KISHON VIJAY
2012-07-10  7:02       ` Rajendra Nayak
2012-06-28 11:51 ` [PATCH v1 08/11] arm/dts: Add twl4030-usb data Kishon Vijay Abraham I
2012-07-10  6:13   ` Rajendra Nayak
2012-07-10  6:55     ` ABRAHAM, KISHON VIJAY
2012-06-28 11:51 ` [PATCH v1 09/11] drivers: usb: musb: Add device tree support for omap musb glue Kishon Vijay Abraham I
2012-07-10  7:14   ` Gupta, Ajay Kumar
2012-06-28 11:51 ` [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data Kishon Vijay Abraham I
2012-07-10  6:27   ` Rajendra Nayak
2012-07-10  8:13     ` ABRAHAM, KISHON VIJAY
2012-07-10  8:32       ` Rajendra Nayak [this message]
2012-06-28 11:51 ` [PATCH v1 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c Kishon Vijay Abraham I
2012-07-10  6:29   ` Rajendra Nayak
2012-07-10  8:16     ` ABRAHAM, KISHON VIJAY
2012-07-10  8:33       ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFBE8A9.6050608@ti.com \
    --to=rnayak@ti$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox