From: lauri.hintsala@bluegiga•com (Lauri Hintsala)
To: linux-arm-kernel@lists•infradead.org
Subject: mmc: mxs: DEADLOCK
Date: Wed, 11 Jul 2012 09:08:26 +0300 [thread overview]
Message-ID: <4FFD185A.8010501@bluegiga.com> (raw)
In-Reply-To: <20120711060607.GE14060@S2101-09.ap.freescale.net>
On 07/11/2012 09:06 AM, Shawn Guo wrote:
>> --- a/drivers/mmc/host/mxs-mmc.c
>> +++ b/drivers/mmc/host/mxs-mmc.c
>> @@ -278,11 +278,11 @@ static irqreturn_t mxs_mmc_irq_handler(int
>> irq, void *dev_id)
>> writel(stat & MXS_MMC_IRQ_BITS,
>> host->base + HW_SSP_CTRL1(host) + STMP_OFFSET_REG_CLR);
>>
>> + spin_unlock(&host->lock);
>> +
>> if ((stat & BM_SSP_CTRL1_SDIO_IRQ) && (stat & BM_SSP_CTRL1_SDIO_IRQ_EN))
>> mmc_signal_sdio_irq(host->mmc);
>>
>> - spin_unlock(&host->lock);
>> -
>> if (stat & BM_SSP_CTRL1_RESP_TIMEOUT_IRQ)
>> cmd->error = -ETIMEDOUT;
>> else if (stat & BM_SSP_CTRL1_RESP_ERR_IRQ)
>>
>>
>> Is there any reason to keep mmc_signal_sdio_irq inside the spinlock?
>> mmc_signal_sdio_irq calls mxs_mmc_enable_sdio_irq and it tries to
>> acquire lock while it is already acquired.
>>
> The fix looks right to me. You can have my ack when you send a patch
> for it.
>
> Acked-by: Shawn Guo <shawn.guo@linaro•org>
OK, I'll send a patch. Thanks!
Lauri
next prev parent reply other threads:[~2012-07-11 6:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 14:04 mmc: mxs: DEADLOCK Lauri Hintsala
2012-07-10 15:02 ` Marek Vasut
2012-07-11 6:10 ` Shawn Guo
2012-07-11 6:06 ` Shawn Guo
2012-07-11 6:08 ` Lauri Hintsala [this message]
2012-07-12 14:00 ` Attila Kinali
2012-07-12 14:39 ` Shawn Guo
2012-07-12 15:13 ` Attila Kinali
2012-07-16 5:57 ` Lauri Hintsala
2012-07-16 12:07 ` Attila Kinali
2012-07-17 4:54 ` Lauri Hintsala
2012-07-17 12:40 ` Shawn Guo
2012-07-17 13:03 ` Lauri Hintsala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD185A.8010501@bluegiga.com \
--to=lauri.hintsala@bluegiga$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox