From: Jae Hyun Yoo <jae.hyun.yoo@linux•intel.com>
To: Tao Ren <taoren@fb•com>,
Brendan Higgins <brendanhiggins@google•com>,
Wolfram Sang <wsa@the-dreams•de>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Joel Stanley <joel@jms•id.au>, Rob Herring <robh+dt@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Andrew Jeffery <andrew@aj•id.au>, Cedric Le Goater <clg@kaod•org>
Cc: "devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linux-aspeed@lists•ozlabs.org" <linux-aspeed@lists•ozlabs.org>,
"linux-i2c@vger•kernel.org" <linux-i2c@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"openbmc@lists•ozlabs.org" <openbmc@lists•ozlabs.org>
Subject: Re: [PATCH] i2c: aspeed: fix master pending state handling
Date: Thu, 10 Oct 2019 16:52:41 -0700 [thread overview]
Message-ID: <4ca4083d-23ff-0475-f5fd-ec3745b440b2@linux.intel.com> (raw)
In-Reply-To: <49244d71-cbc3-f2ae-97ac-74b5f68a4816@fb.com>
On 10/10/2019 4:29 PM, Tao Ren wrote:
> On 10/9/19 2:20 PM, Jae Hyun Yoo wrote:
>> In case of master pending state, it should not trigger a master
>> command, otherwise data could be corrupted because this H/W shares
>> the same data buffer for slave and master operations. It also means
>> that H/W command queue handling is unreliable because of the buffer
>> sharing issue. To fix this issue, it clears command queue if a
>> master command is queued in pending state to use S/W solution
>> instead of H/W command queue handling. Also, it refines restarting
>> mechanism of the pending master command.
>>
>> Fixes: 2e57b7cebb98 ("i2c: aspeed: Add multi-master use case support")
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux•intel.com>
>
> Tested-by: Tao Ren <taoren@fb•com>
>
> Tested the patch on Facebook Minipack BMC (multi-master i2c-0 environment) and
> everything looks good to me.
Thanks for sharing the test result and your code reviews.
Best,
Jae
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-10 23:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 21:20 [PATCH] i2c: aspeed: fix master pending state handling Jae Hyun Yoo
2019-10-10 0:32 ` Brendan Higgins
2019-10-10 1:26 ` Tao Ren
2019-10-10 6:37 ` Wolfram Sang
2019-10-10 6:48 ` Joel Stanley
2019-10-10 18:22 ` Jae Hyun Yoo
2019-10-10 21:20 ` Tao Ren
2019-10-10 22:04 ` Jae Hyun Yoo
2019-10-10 23:11 ` Tao Ren
2019-10-10 23:16 ` Jae Hyun Yoo
2019-10-10 23:24 ` Tao Ren
2019-10-10 23:29 ` Tao Ren
2019-10-10 23:52 ` Jae Hyun Yoo [this message]
2019-10-16 19:20 ` Brendan Higgins
2019-10-21 12:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca4083d-23ff-0475-f5fd-ec3745b440b2@linux.intel.com \
--to=jae.hyun.yoo@linux$(echo .)intel.com \
--cc=andrew@aj$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=brendanhiggins@google$(echo .)com \
--cc=clg@kaod$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=joel@jms$(echo .)id.au \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-aspeed@lists$(echo .)ozlabs.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=openbmc@lists$(echo .)ozlabs.org \
--cc=robh+dt@kernel$(echo .)org \
--cc=taoren@fb$(echo .)com \
--cc=wsa@the-dreams$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox