Subject: Re: [PATCH v3 1/1] arm64: defconfig: Enable CIX Sky1 pinctrl, PCIe host, and Cadence GPIO

From: Krzysztof Kozlowski <[email-masked]>
Date: Thu, 21 May 2026 17:23:41 +0200

On 27/03/2026 12:46, Peter Chen wrote:
> Enable the CIX Sky1 pinctrl driver (PINCTRL_SKY1), CIX Sky1 PCIe host
> controller (PCI_SKY1_HOST), and Cadence GPIO controller (GPIO_CADENCE)
> for the Radxa Orion O6 board which uses the CIX Sky1 SoC.
> 
> The pinctrl driver is a dependency for other on-SoC peripherals. The
> Cadence-based PCIe host controller enables use of PCIe peripherals on
> the board. The Cadence GPIO controller provides GPIO support for the
> SoC.
> 
> Cc: Yunseong Kim <[email-masked]>
> Signed-off-by: Peter Chen <[email-masked]>
> ---
> Changes for v3:
> - Use specific driver names (CIX Sky1 pinctrl, CIX Sky1 PCIe host
>   controller, Cadence GPIO) in subject and commit message instead of
>   generic terms.
> - Remove external Debian bug reference; explain rationale directly.
> - Remove NVMe mention since only PCIe host controller is enabled.
> 
> Changes for v2:
> - Delete CIX HDA configurations due to it is not used at current
>   Orion O6 board device tree.
> 
>  arch/arm64/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index b67d5b1fc45b..f9be52484008 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -241,6 +241,7 @@ CONFIG_PCIE_XILINX_DMA_PL=y
>  CONFIG_PCIE_XILINX_NWL=y
>  CONFIG_PCIE_XILINX_CPM=y
>  CONFIG_PCI_J721E_HOST=m
> +CONFIG_PCI_SKY1_HOST=m

This is not correctly placed and caused issues later - conflicts with my
cleanup patch.

Please fix it up before you send the patch to soc@.

Best regards,
Krzysztof