From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 5/7] ARM: davinci: i2c: add OF support
Date: Mon, 16 Jul 2012 21:46:17 +0530 [thread overview]
Message-ID: <50043E51.8070702@ti.com> (raw)
In-Reply-To: <5000F276.3080301@denx.de>
On 7/14/2012 9:45 AM, Heiko Schocher wrote:
> Hello Sekhar,
>
> On 13.07.2012 15:57, Sekhar Nori wrote:
>> Hi Heiko,
>>
>> On 5/30/2012 3:49 PM, Heiko Schocher wrote:
>>> add of support for the davinci i2c driver.
>>>
>>> Signed-off-by: Heiko Schocher<hs@denx•de>
>>> Cc: davinci-linux-open-source at linux.davincidsp.com
>>> Cc: linux-arm-kernel at lists.infradead.org
>>> Cc: devicetree-discuss at lists.ozlabs.org
>>> Cc: linux-i2c at vger.kernel.org
>>> Cc: Ben Dooks<ben-linux@fluff•org>
>>> Cc: Wolfram Sang<w.sang@pengutronix•de>
>>> Cc: Grant Likely<grant.likely@secretlab•ca>
>>> Cc: Sekhar Nori<nsekhar@ti•com>
>>> Cc: Wolfgang Denk<wd@denx•de>
>>> Cc: Sylwester Nawrocki<s.nawrocki@samsung•com>
> [...]
[...]
>>> diff --git a/drivers/i2c/busses/i2c-davinci.c
>>> b/drivers/i2c/busses/i2c-davinci.c
>>> index a76d85f..4e7a966 100644
>>> --- a/drivers/i2c/busses/i2c-davinci.c
>>> +++ b/drivers/i2c/busses/i2c-davinci.c
[...]
>>> static int davinci_i2c_probe(struct platform_device *pdev)
>>> {
>>> struct davinci_i2c_dev *dev;
>>> @@ -676,6 +695,25 @@ static int davinci_i2c_probe(struct
>>> platform_device *pdev)
>>> dev->irq = irq->start;
>>> platform_set_drvdata(pdev, dev);
>>>
>>> + if ((dev->dev->platform_data == NULL)&&
>>> + (pdev->dev.of_node)) {
>>> + u32 prop;
>>> +
>>> + dev->pdata = devm_kzalloc(&pdev->dev,
>>> + sizeof(struct davinci_i2c_platform_data), GFP_KERNEL);
>>> + if (!dev->pdata) {
>>> + r = -ENOMEM;
>>> + goto err_free_mem;
>>> + }
>>> + memcpy(dev->pdata,&davinci_i2c_platform_data_default,
>>> + sizeof(struct davinci_i2c_platform_data));
>>> + if (!of_property_read_u32(pdev->dev.of_node, "clock-frequency",
>>> + &prop))
>>> + dev->pdata->bus_freq = prop / 1000;
>>> + if (!of_property_read_u32(pdev->dev.of_node, "bus-delay",
>>> + &prop))
>>> + dev->pdata->bus_delay = prop;
>>
>> You are leaving out two other platform data members (the gpio pins
>> corresponding to data and clock) from DT data. We should be able to
>> get that information from DT too, right?
>
> Yes, but I had not ported the GPIO driver to OF ...
Okay. Understood. They can added once GPIO has been ported too and this
part is tested.
>
>> So, I took this patch and tried to see if pdata maintenance can be
>> simplified and came with the diff below. Can you have a look and see
>> if this makes sense? I tested this using i2cdetect both with and
>> without DT.
>
> Tested your patch on the enbw_cmc board with a LM75 on the enbw_cmc
> board, works fine. Can I post a "v6" of my patch, merged with your
> patch below and your Signed-off?
Yes, please do. You can post it as in independent patch (not as part of
a series) since the patch does not have any dependencies.
Thanks,
Sekhar
next prev parent reply other threads:[~2012-07-16 16:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 10:18 [PATCH v5 0/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2012-05-30 10:18 ` [PATCH v5 1/7] ARM: davinci, cp_intc: Add irq domain support Heiko Schocher
2012-06-01 19:36 ` Sekhar Nori
2012-06-12 17:36 ` Sekhar Nori
2012-06-13 9:50 ` Heiko Schocher
2012-06-25 17:15 ` Sekhar Nori
2012-06-26 6:54 ` Heiko Schocher
2012-05-30 10:18 ` [PATCH v5 2/7] ARM: davinci, cp_intc: Add OF support for TI interrupt controller Heiko Schocher
2012-07-03 19:09 ` Sekhar Nori
2012-05-30 10:18 ` [PATCH v5 3/7] ARM: davinci: configure davinci aemif chipselects through OF Heiko Schocher
2012-05-30 10:19 ` [PATCH v5 4/7] ARM: davinci: net: davinci_emac: add OF support Heiko Schocher
2012-07-08 14:26 ` Sekhar Nori
2012-07-09 8:25 ` Heiko Schocher
2012-05-30 10:19 ` [PATCH v5 5/7] ARM: davinci: i2c: " Heiko Schocher
2012-07-13 13:57 ` Sekhar Nori
2012-07-14 4:15 ` Heiko Schocher
2012-07-16 16:16 ` Sekhar Nori [this message]
2012-05-30 10:19 ` [PATCH v5 6/7] ARM: mtd: nand: davinci: add OF support for davinci nand controller Heiko Schocher
2012-07-18 17:45 ` Sekhar Nori
2012-05-30 10:19 ` [PATCH v5 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50043E51.8070702@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox