public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: jy0922.shim@samsung•com (Joonyoung Shim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 4/7] ARM: EXYNOS: Adding DRM platform device
Date: Fri, 20 Jul 2012 16:33:52 +0900	[thread overview]
Message-ID: <500909E0.5070608@samsung.com> (raw)
In-Reply-To: <1342591053-7092-5-git-send-email-l.krishna@samsung.com>

On 07/18/2012 02:57 PM, Leela Krishna Amudala wrote:
> Add DRM platform device to machine file for exynos5.
>
> Signed-off-by: Prathyush K <prathyush.k@samsung•com>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung•com>
> ---
>   arch/arm/mach-exynos/mach-exynos5-dt.c |   27 +++++++++++++++++++++++++++
>   1 files changed, 27 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
> index 02a0e68..99f2b24 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -17,6 +17,7 @@
>   
>   #include <asm/mach/arch.h>
>   #include <asm/hardware/gic.h>
> +#include <asm/io.h>
>   #include <mach/map.h>
>   
>   #include <plat/cpu.h>
> @@ -27,6 +28,22 @@
>   #include "common.h"
>   #include <video/platform_lcd.h>
>   
> +static void exynos_fimd_gpio_setup_24bpp(void)

The function name is wrong, this function doesn't control gpios.

> +{
> +	unsigned int reg = 0;
> +	/*
> +	 * Set DISP1BLK_CFG register for Display path selection
> +	 * FIMD of DISP1_BLK Bypass selection : DISP1BLK_CFG[15]
> +	 * ---------------------
> +	 * 0 | MIE/MDNIE
> +	 * 1 | FIMD : selected
> +	 */
> +	reg = __raw_readl(S3C_VA_SYS + 0x0214);
> +	reg &= ~(1 << 15);      /* To save other reset values */
> +	reg |= (1 << 15);
> +	__raw_writel(reg, S3C_VA_SYS + 0x0214);
> +}

If needs this, move to arch/arm/mach-exynos/setup-fimd0.c

> +
>   static int smdk5250_bl_notify(struct device *unused, int brightness)
>   {
>   	/* manage lcd_bl_en signal */
> @@ -49,6 +66,14 @@ static struct platform_pwm_backlight_data smdk5250_bl_data = {
>   	.notify		= smdk5250_bl_notify,
>   };
>   
> +static struct platform_device exynos_drm_device = {
> +	.name		= "exynos-drm",
> +	.dev = {
> +		.dma_mask = &exynos_drm_device.dev.coherent_dma_mask,
> +		.coherent_dma_mask = 0xffffffffUL,
> +	}
> +};
> +

There is already exynos-drm device at the arch/arm/mach-exynos/dev-drm.c

>   static void lcd_set_power(struct plat_lcd_data *pd,
>   			unsigned int power)
>   {
> @@ -138,6 +163,7 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
>   
>   static struct platform_device *smdk5250_devices[] __initdata = {
>   	&smdk5250_lcd, /* for platform_lcd device */
> +	&exynos_drm_device,
>   };
>   
>   static void __init exynos5250_dt_map_io(void)
> @@ -151,6 +177,7 @@ static void __init exynos5250_dt_machine_init(void)
>   	samsung_bl_set(&smdk5250_bl_gpio_info, &smdk5250_bl_data);
>   	of_platform_populate(NULL, of_default_bus_match_table,
>   				exynos5250_auxdata_lookup, NULL);
> +	exynos_fimd_gpio_setup_24bpp();
>   	platform_add_devices(smdk5250_devices, ARRAY_SIZE(smdk5250_devices));
>   }
>   

Thanks.

  reply	other threads:[~2012-07-20  7:33 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  5:57 [PATCH V2 0/7] Add device tree based discovery support for drm-fimd Leela Krishna Amudala
2012-07-18  5:57 ` [PATCH V2 1/7] ARM: SAMSUNG: add additional registers and SFR definitions for writeback Leela Krishna Amudala
2012-07-18  6:51   ` Marek Szyprowski
2012-07-18  7:09     ` Ajay kumar
2012-07-20 10:09       ` Sylwester Nawrocki
2012-07-19 12:43     ` Leela Krishna Amudala
2012-07-20  6:45       ` Marek Szyprowski
2012-07-18 11:05   ` Tomasz Figa
2012-07-19 13:00     ` Leela Krishna Amudala
2012-07-19 13:35       ` Tomasz Figa
2012-07-20  2:21         ` Jingoo Han
2012-07-20  2:59           ` Leela Krishna Amudala
2012-07-20  9:49             ` Tomasz Figa
2012-07-20 10:00             ` Sylwester Nawrocki
2012-07-20 11:07               ` Leela Krishna Amudala
2012-07-20 12:54                 ` Sylwester Nawrocki
2012-07-22 22:35               ` Jingoo Han
2012-07-18  5:57 ` [PATCH V2 2/7] ARM: EXYNOS5: add machine specific support for backlight Leela Krishna Amudala
2012-07-18  5:57 ` [PATCH V2 3/7] ARM: EXYNOS5: add machine specific support for LCD Leela Krishna Amudala
2012-07-18  6:45   ` Marek Szyprowski
2012-07-19 13:21     ` Leela Krishna Amudala
2012-07-20  6:31       ` Marek Szyprowski
2012-07-24 16:02         ` Leela Krishna Amudala
2012-07-20  7:17       ` Joonyoung Shim
2012-07-18  5:57 ` [PATCH V2 4/7] ARM: EXYNOS: Adding DRM platform device Leela Krishna Amudala
2012-07-20  7:33   ` Joonyoung Shim [this message]
2012-07-18  5:57 ` [PATCH V2 5/7] ARM: EXYNOS: add device tree based discovery support for FIMD Leela Krishna Amudala
2012-07-20  7:39   ` Joonyoung Shim
2012-07-18  5:57 ` [PATCH V2 6/7] ARM: EXYNOS5: Add the bus clock " Leela Krishna Amudala
2012-07-23  8:34   ` Joonyoung Shim
2012-07-23  9:54     ` Joonyoung Shim
2012-07-23 23:14       ` Jingoo Han
2012-07-23 23:45         ` Joonyoung Shim
2012-07-23 23:48           ` Jingoo Han
2012-07-23 23:55           ` Jingoo Han
2012-07-24  1:55             ` Joonyoung Shim
2012-07-24  2:15               ` Jingoo Han
2012-07-24  3:06                 ` Joonyoung Shim
2012-07-24  4:02                   ` Jingoo Han
2012-07-24  9:13                     ` Sylwester Nawrocki
2012-07-18  5:57 ` [PATCH V2 7/7] ARM: EXYNOS5: Set parent clock to fimd Leela Krishna Amudala
2012-07-23  8:41   ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500909E0.5070608@samsung.com \
    --to=jy0922.shim@samsung$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox