From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO
Date: Fri, 27 Jul 2012 22:04:52 +0300 [thread overview]
Message-ID: <5012E654.4040907@compulab.co.il> (raw)
In-Reply-To: <87sjcdksgm.fsf@ti.com>
On 07/27/12 20:46, Kevin Hilman wrote:
> Igor Grinberg <grinberg@compulab•co.il> writes:
>
>> On 07/26/12 22:30, Kevin Hilman wrote:
>>> + Zumeng Chen
>>>
>>> Igor Grinberg <grinberg@compulab•co.il> writes:
>>>
>>>> Hi Kevin,
>>>>
>>>> I've just noticed that the patch has been modified by Arnd in a way
>>>> that of course will trigger GPIO use without being requested.
>>>> I'm sorry, I was not available by that time Arnd changed the patch.
>>>
>>> Your right, your original patch isn't the problem. I found the root
>>> cause.
>>>
>>> The real problem is actually introduced by the merge of your patch from
>>> the arm-soc/cleanup branch, and this one from Zumeng Chen: commit
>>> 16aced80f6 (ARM: OMAP3530evm: set pendown_state and debounce time for
>>> ads7846) from the arm-soc/boards branch.
>>>
>>> However, looking closer at the one from Zumeng, that one is clearly not
>>> right. It unconditionally adds a *board-specific* ->get_pendown_state
>>> function to the pdata that is common to *all* boards. That's just wrong
>>> and has the side-effect of making ->get_pendown_state() wrong on every
>>> board except the OMAP3EVM. Oops.
>>
>> Argh... that should not be applied in first place...
>
> Agreed, but it's already in mainline.
>
>> I double sorry, I was not available when that conflict was resolved...
>> The right resolution would be just to revert the 16aced80f6
>> (ARM: OMAP3530evm: set pendown_state and debounce time for ads7846),
>> but who cares now...
>
>
>>
>>>
>>> So, IMO, in addition to $SUBJECT patch, in order to get the touchscreen
>>> GPIO working on non OMAP3EVM boards, we also need something like this as
>>> well.
>>>
>>> Igor, Zumeng, could you try this out on your boards anc confirm if it's
>>> working? I currently don't have a board setup with a touchscreen in my
>>> board farm.
>>
>> Since you have already dig into this, which branch would be good for testing?
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.6/fixes/ads7846
>
> I just pushed this out, so it might take a bit to propagate to all the
> mirrors.
Thanks, Kevin, I've just sent the tested-by.
I would also like to see only one patch instead of current two patches,
can you please, amend them into one, write a correct message and resend?
--
Regards,
Igor.
next prev parent reply other threads:[~2012-07-27 19:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 23:18 [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO Kevin Hilman
2012-07-23 12:53 ` Igor Grinberg
2012-07-23 13:18 ` Igor Grinberg
2012-07-26 19:30 ` Kevin Hilman
2012-07-26 21:19 ` zumeng.chen
2012-07-26 21:58 ` Kevin Hilman
2012-07-26 22:40 ` zumeng.chen
2012-07-27 5:02 ` Zumeng Chen
2012-07-27 15:30 ` Igor Grinberg
2012-07-27 17:46 ` Kevin Hilman
2012-07-27 19:04 ` Igor Grinberg [this message]
2012-07-28 0:28 ` Kevin Hilman
2012-08-06 20:22 ` [PATCH] Revert "ARM: OMAP3530evm: set pendown_state and debounce time for ads7846" Igor Grinberg
2012-08-06 20:52 ` Kevin Hilman
2012-08-07 1:44 ` Zumeng Chen
2012-08-07 5:58 ` Igor Grinberg
2012-08-07 10:58 ` Tony Lindgren
2012-08-07 1:42 ` Zumeng Chen
2012-08-07 6:05 ` Igor Grinberg
2012-07-27 18:58 ` [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO Igor Grinberg
2012-07-27 19:05 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5012E654.4040907@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox