From: hvaibhav@ti•com (Vaibhav Hiremath)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence
Date: Fri, 3 Aug 2012 10:54:47 +0530 [thread overview]
Message-ID: <501B609F.9030403@ti.com> (raw)
In-Reply-To: <CALLhW=6-b+kjfG-u3+uXiD64UwoNEdufjJKu0Mx-sGWp6n9csg@mail.gmail.com>
On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote:
> Hi.
>
> On 2 August 2012 02:52, Paul Walmsley <paul@pwsan•com> wrote:
>> On Mon, 16 Jul 2012, Omar Ramirez Luna wrote:
>>
>>> For a reset sequence to complete cleanly, a module needs its
>>> associated clocks to be enabled, otherwise the timeout check
>>> in prcm code can print a false failure (failed to hardreset)
>>> that occurs because the clocks aren't powered ON and the status
>>> bit checked can't transition without them.
>>>
>>> Signed-off-by: Omar Ramirez Luna <omar.luna@linaro•org>
>>
>> Is enabling the clocks sufficient?
>
> During my testing it seemed enough, besides it looks clk framework is
> doing the same as _omap4_enable_module.
>
>> Or do we also need to enable the
>> IP block, e.g. by calling
>>
>> if (soc_ops.enable_module)
>> soc_ops.enable_module(oh);
>>
>> as we do on OMAP4+ in _enable() ?
>
> Basically this is a call to _omap4_enable_module, and the latter will
> "Enable the modulemode inside CLKCTRL".
>
> However, _enable_clocks path which ends calling omap2_dflt_clk_enable
> does the same thing with its clk->enable_reg field.
>
> So in _enable:
>
> _enable_clocks(oh);
> if (soc_ops.enable_module)
> soc_ops.enable_module(oh);
>
> The enable_module part seems redundant to me, since the module should
> be already enabled by the first call to _enable_clocks.
>
Yes they do same thing, I believe the plan is to get rid of all clock
leaf-nodes in the near future, and let hwmod handle module
enable/disable part.
Thanks,
Vaibhav
> Regards,
>
> Omar
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-08-03 5:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 19:21 [PATCH 0/3] OMAP: hwmod: reset API proposal Omar Ramirez Luna
2012-07-16 19:21 ` [PATCH 1/3] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled Omar Ramirez Luna
2012-08-20 14:49 ` Benoit Cousson
2012-08-21 1:13 ` Omar Ramirez Luna
2012-08-21 17:48 ` Omar Ramirez Luna
2012-07-16 19:21 ` [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence Omar Ramirez Luna
2012-08-02 7:52 ` Paul Walmsley
2012-08-02 22:20 ` Omar Ramirez Luna
2012-08-03 5:24 ` Vaibhav Hiremath [this message]
2012-08-03 15:52 ` Omar Ramirez Luna
2012-08-20 10:21 ` Benoit Cousson
2012-08-21 1:15 ` Omar Ramirez Luna
2012-07-16 19:21 ` [PATCH 3/3] ARM: OMAP: omap_device: expose hwmod assert/deassert to omap devices Omar Ramirez Luna
2012-08-02 7:43 ` Paul Walmsley
2012-08-02 17:56 ` Omar Ramirez Luna
-- strict thread matches above, loose matches on Subject: below --
2012-06-16 1:54 [PATCH 0/3] OMAP: hwmod: reset API proposal Omar Ramirez Luna
2012-06-16 1:54 ` [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501B609F.9030403@ti.com \
--to=hvaibhav@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox