From: ludovic.desroches@atmel•com (ludovic.desroches)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mmc: atmel-mci: not busy flag has also to be used for read operations
Date: Thu, 9 Aug 2012 08:29:15 +0200 [thread overview]
Message-ID: <502358BB.8010801@atmel.com> (raw)
In-Reply-To: <87lihqxev6.fsf@octavius.laptop.org>
Le 08/08/2012 05:05 AM, Chris Ball a ?crit :
> Hi,
>
> On Tue, Jul 24 2012, ludovic.desroches at atmel.com wrote:
>> From: Ludovic Desroches <ludovic.desroches@atmel•com>
>>
>> Even if the datasheet says that the not busy flag has to be used only for
>> write operations, it's false excepted for version lesser than v2xx.
>> Not waiting the not busy flag for read operations can cause the controller to
>> hang-up during the initialization of some SD cards.
>>
>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel•com>
>> Cc: stable at vger.kernel.org
>>
>>
>> Hello,
>>
>> This is a fix for 3.5 and later.
>>
>> Due to the big changes into atmel-mci driver to support all atmel mci versions,
>> a bug was introduced.
>> With some SD cards (mainly micro) when using DMA, the controller hangs-up after
>> the first CMD6 command because the next command is sent too early.
>>
>> Regards
>>
>> Ludovic
>>
>>
>> ---
>> drivers/mmc/host/atmel-mci.c | 6 +++++-
>> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> Thanks. I've applied this for mmc-next now, but please put your patch
> commentary *underneath* the "---" lines, so that it doesn't end up in
> the git history itself. I've rewritten the commit message to be:
Sorry for this error.
Thanks
Ludovic
>
>
> From: Ludovic Desroches <ludovic.desroches@atmel•com>
>
> Even if the datasheet says that the not busy flag has to be used only
> for write operations, it's false except for version lesser than v2xx.
>
> Not waiting on the not busy flag for read operations can cause the
> controller to hang-up during the initialization of some SD cards
> with DMA after the first CMD6 -- the next command is sent too early.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel•com>
> Cc: stable <stable@vger•kernel.org> [3.5, 3.6]
> Signed-off-by: Chris Ball <cjb@laptop•org>
> ---
> <patch commentary can go here>
>
> drivers/mmc/host/atmel-mci.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
prev parent reply other threads:[~2012-08-09 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 9:42 [PATCH] mmc: atmel-mci: not busy flag has also to be used for read operations ludovic.desroches at atmel.com
2012-08-08 3:05 ` Chris Ball
2012-08-09 6:29 ` ludovic.desroches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502358BB.8010801@atmel.com \
--to=ludovic.desroches@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox