From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/5] ASoC/ARM: Davinci: McASP: split asp header into platform and audio specific
Date: Fri, 17 Aug 2012 23:43:44 +0530 [thread overview]
Message-ID: <502E89D8.2090304@ti.com> (raw)
In-Reply-To: <1344948125-5649-2-git-send-email-gururaja.hebbar@ti.com>
Hi Gururaja,
On 8/14/2012 6:12 PM, Hebbar, Gururaja wrote:
> Davinci McASP header & driver are shared by few OMAP platforms (like
> TI81xx, AM335x). Splitting asp header into Davinci platform specific
> header and Audio specific header helps to share them across platforms.
>
> Audio specific defines is moved to to common
> <linux/platform_data/davinci_asp.h> so that the header can be
> accessed by all related platforms.
>
> While here, correct the header usage (remove multiple header
> re-definitions and unused headers) and remove platform names from
> structures comments and enum
>
> Signed-off-by: Hebbar, Gururaja <gururaja.hebbar@ti•com>
> Acked-by: Vaibhav Bedia <vaibhav.bedia@ti•com>
This patch looks good to me. See a minor nit below.
Acked-by: Sekhar Nori <nsekhar@ti•com>
> diff --git a/arch/arm/mach-davinci/asp.h b/arch/arm/mach-davinci/asp.h
> new file mode 100644
> index 0000000..8fd5238
> --- /dev/null
> +++ b/arch/arm/mach-davinci/asp.h
> @@ -0,0 +1,49 @@
> +/*
> + * TI DaVinci Audio definitions
> + */
> +#ifndef __ASM_ARCH_DAVINCI_ASP_H
> +#define __ASM_ARCH_DAVINCI_ASP_H
> +
> +/* Bases of dm644x and dm355 register banks */
> +#define DAVINCI_ASP0_BASE 0x01E02000
> +#define DAVINCI_ASP1_BASE 0x01E04000
> +
> +/* Bases of dm365 register banks */
> +#define DAVINCI_DM365_ASP0_BASE 0x01D02000
> +
> +/* Bases of dm646x register banks */
> +#define DAVINCI_DM646X_MCASP0_REG_BASE 0x01D01000
> +#define DAVINCI_DM646X_MCASP1_REG_BASE 0x01D01800
Can you remove usage of tabs after 'define'. I understand this is coming
from existing code.
Thanks,
Sekhar
next prev parent reply other threads:[~2012-08-17 18:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 12:42 [PATCH 0/5] ARM/ASoC: Davinci: Add Device Tree Support Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 1/5] ASoC/ARM: Davinci: McASP: split asp header into platform and audio specific Hebbar, Gururaja
2012-08-17 18:13 ` Sekhar Nori [this message]
2012-08-22 7:06 ` Hebbar, Gururaja
2012-08-17 22:33 ` Mark Brown
2012-08-22 13:11 ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 2/5] ASoC: Davinci: McASP: add device tree support for McASP Hebbar, Gururaja
2012-08-17 22:41 ` Mark Brown
2012-08-23 7:56 ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 3/5] ASoC: Davinci: pcm: Add device tree bindings Hebbar, Gururaja
2012-08-17 22:31 ` Mark Brown
2012-08-22 13:50 ` Hebbar, Gururaja
2012-08-22 15:58 ` Mark Brown
2012-08-23 5:13 ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 4/5] ASoC: Davinci: machine: Add device tree binding Hebbar, Gururaja
2012-08-17 22:43 ` Mark Brown
2012-08-22 11:35 ` Hebbar, Gururaja
2012-08-14 12:42 ` [PATCH 5/5] ASoC: tlv320aic3x: Add device tree bindings Hebbar, Gururaja
2012-08-17 22:45 ` Mark Brown
2012-08-22 9:26 ` Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502E89D8.2090304@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox